Skip to content

Parametrize the registry name of the provider#462

Merged
sergenyalcin merged 1 commit intocrossplane:mainfrom
sergenyalcin:parametrize-registry
Jan 23, 2025
Merged

Parametrize the registry name of the provider#462
sergenyalcin merged 1 commit intocrossplane:mainfrom
sergenyalcin:parametrize-registry

Conversation

@sergenyalcin
Copy link
Member

@sergenyalcin sergenyalcin commented Jan 23, 2025

Description of your changes

This PR parametrizes the registry name of the provider. For some private registries the hardcoded registry is not valid.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@sergenyalcin sergenyalcin marked this pull request as ready for review January 23, 2025 13:11
@sergenyalcin
Parametrize the registry name of the provider
5dbd74a 
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
mergenci
mergenci approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin 🙏 LGTM.

@sergenyalcin sergenyalcin merged commit 40ef4d8 into crossplane:main Jan 23, 2025
@sergenyalcin sergenyalcin deleted the parametrize-registry branch January 23, 2025 14:56
@github-actions
Copy link

github-actions bot commented Jan 23, 2025

Successfully created backport PR for release-1.4:

@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
mergenci added a commit to mergenci/provider-aws that referenced this pull request Jan 30, 2025
@mergenci
Bump Upjet to commit ce71033d450f.
2220da3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci mergenci mentioned this pull request Jan 30, 2025
Merged
3 tasks
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 5, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
c7b7af3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
b1a4d4a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
858d67d 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
717614a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9bb6045 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9b7a411 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
786f94a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
01d824f 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9f3a19a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
65b75ce 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9a5d1d7 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergenci mergenci mergenci approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

Assignees

No one assigned

Labels

backport release-1.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergenyalcin @mergenci