Skip to content

fix: typo in example#450

Merged
mergenci merged 1 commit intocrossplane:mainfrom
fernandezcuesta:patch-1
Dec 29, 2024
Merged

fix: typo in example#450
mergenci merged 1 commit intocrossplane:mainfrom
fernandezcuesta:patch-1

Conversation

@fernandezcuesta
Copy link
Contributor

@fernandezcuesta fernandezcuesta commented Nov 13, 2024

Description of your changes

There's a syntax error in the upjet external name documentation.

I have:

  • Read and followed Upjet's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

n/a
[contribution process]: https://github.com/crossplane/upjet/blob/main/CONTRIBUTING.md

@fernandezcuesta
fix: typo in example
8642d46 
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
mergenci
mergenci approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fernandezcuesta 🙏 Documentation fixes are my favorite 😎

@mergenci mergenci merged commit a10b5b9 into crossplane:main Dec 29, 2024
mergenci added a commit to mergenci/provider-aws that referenced this pull request Jan 30, 2025
@mergenci
Bump Upjet to commit ce71033d450f.
2220da3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci mergenci mentioned this pull request Jan 30, 2025
Merged
3 tasks
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 5, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
c7b7af3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
b1a4d4a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
858d67d 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
717614a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9bb6045 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9b7a411 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
786f94a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
01d824f 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9f3a19a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
65b75ce 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9a5d1d7 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergenci mergenci mergenci approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernandezcuesta @mergenci