Skip to content

Update GH action dependencies and linter config#451

Merged
mergenci merged 4 commits intocrossplane:mainfrom
erhancagirici:ci-chores
Jan 8, 2025
Merged

Update GH action dependencies and linter config#451
mergenci merged 4 commits intocrossplane:mainfrom
erhancagirici:ci-chores

Conversation

@erhancagirici
Copy link
Collaborator

@erhancagirici erhancagirici commented Nov 13, 2024

Description of your changes

  • switch build submodule to crossplane/build repo
  • update linter config & remove deprecations
  • update GH action dependency versions

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

CI

@erhancagirici
switch build submodule to crossplane/build repo
fcb3112 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
update linter config & remove deprecations
57535ad 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
update GH action dependency versions
deff690 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
mergenci
mergenci approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@mergenci mergenci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erhancagirici 🙏 This PR resolves linter issues in #437. Please see my minor change suggestion below.

.gitmodules Outdated
[submodule "build"]
path = build
url = https://github.com/upbound/build
url = https://github.com/crossplane/build
Copy link
Member

@mergenci mergenci Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = https://github.com/crossplane/build
url = https://github.com/crossplane/build

Indentation seems unintentional to me.

@mergenci mergenci mentioned this pull request Dec 27, 2024
Merged
@mergenci
Remove unintentional indentation.
04d0b9f 
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci mergenci merged commit beb604b into crossplane:main Jan 8, 2025
mergenci added a commit to mergenci/provider-aws that referenced this pull request Jan 30, 2025
@mergenci
Bump Upjet to commit ce71033d450f.
2220da3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci mergenci mentioned this pull request Jan 30, 2025
Merged
3 tasks
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 5, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
c7b7af3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
b1a4d4a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
858d67d 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
717614a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9bb6045 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9b7a411 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
786f94a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
01d824f 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9f3a19a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
65b75ce 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9a5d1d7 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergenci mergenci mergenci approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erhancagirici @mergenci