Skip to content

Fix TestNewKubernetesSource sporadic#454

Merged
ulucinar merged 1 commit intocrossplane:mainfrom
ulucinar:fix-kssource-test
Nov 23, 2024
Merged

Fix TestNewKubernetesSource sporadic#454
ulucinar merged 1 commit intocrossplane:mainfrom
ulucinar:fix-kssource-test

Conversation

@ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Nov 22, 2024 •
edited
Loading

Description of your changes

Fixes #275

This PR proposes a fix for the TestNewKubernetesSource sporadic by comparing the sorted slices of UnstructuredWithMetadata objects.

I have:

  • Read and followed Upjet's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Locally ran the test 100 times with cache disabled.

@ulucinar
Fix TestNewKubernetesSource sporadic
3982f4c 
- Compare sorted expected and observed slices.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
sergenyalcin
sergenyalcin approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 4d4ed3d into crossplane:main Nov 23, 2024
@ulucinar ulucinar deleted the fix-kssource-test branch November 23, 2024 12:57
mergenci added a commit to mergenci/provider-aws that referenced this pull request Jan 30, 2025
@mergenci
Bump Upjet to commit ce71033d450f.
2220da3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci mergenci mentioned this pull request Jan 30, 2025
Merged
3 tasks
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 5, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
c7b7af3 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
b1a4d4a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 14, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
858d67d 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
717614a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9bb6045 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9b7a411 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
786f94a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
01d824f 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9f3a19a 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
65b75ce 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
ido-re pushed a commit to ido-re/provider-upjet-aws that referenced this pull request Mar 24, 2025
@mergenci @ido-re
Bump Upjet to commit ce71033d450f.
9a5d1d7 
Consumed Upjet PRs:

- crossplane/upjet#454
- crossplane/upjet#450
- crossplane/upjet#451
- crossplane/upjet#437
- crossplane/upjet#462
- crossplane/upjet#461

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: ido-re <ido.reychan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergenyalcin sergenyalcin sergenyalcin approved these changes

@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

@mergenci mergenci Awaiting requested review from mergenci

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky TestNewKubernetesSource/Successful unit test

2 participants

@ulucinar @sergenyalcin