Skip to content

Updates the grok patterns to be consistent with the logstash#27181

Merged
jakelandis merged 4 commits intoelastic:masterfrom
austintp:ingest-grok-pattern-uripath-ampersand-support
Feb 5, 2019
Merged

Updates the grok patterns to be consistent with the logstash#27181
jakelandis merged 4 commits intoelastic:masterfrom
austintp:ingest-grok-pattern-uripath-ampersand-support

Conversation

@austintp
Copy link
Copy Markdown
Contributor

@austintp austintp commented Oct 30, 2017

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 30, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ywelsch ywelsch requested a review from talevy November 15, 2017 11:41
@ywelsch ywelsch added the :Distributed/Ingest Node Execution or management of Ingest Pipelines label Nov 15, 2017
@talevy
Copy link
Copy Markdown
Contributor

talevy commented Nov 27, 2017

thanks for the PR @austintp. mind signing our CLA? Once you do, I will be happy to merge your changes and follow-up with a full-resync of the logstash-patterns-core repo into Ingest Node.

@austintp
Copy link
Copy Markdown
Contributor Author

austintp commented Dec 12, 2017 •
edited
Loading

@talevy - Sorry for the delay. I've now signed the CLA.

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Dec 30, 2017

Hi @austintp, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 30, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@austintp
Copy link
Copy Markdown
Contributor Author

austintp commented Dec 30, 2017

@karmi Done.

@jakelandis jakelandis self-requested a review December 6, 2018 21:37
@pcsanwald
Copy link
Copy Markdown
Contributor

pcsanwald commented Jan 3, 2019

@jakelandis will you review this PR?

@jakelandis
Copy link
Copy Markdown
Contributor

jakelandis commented Jan 31, 2019

@elasticmachine ok to test

@jakelandis
Copy link
Copy Markdown
Contributor

jakelandis commented Jan 31, 2019

@elasticmachine test this please

@jakelandis
Copy link
Copy Markdown
Contributor

jakelandis commented Feb 1, 2019

@elasticmachine run elasticsearch-ci/1

@jakelandis
Copy link
Copy Markdown
Contributor

jakelandis commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/2

@jakelandis
Copy link
Copy Markdown
Contributor

jakelandis commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/1

jakelandis
jakelandis approved these changes Feb 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @austintp ! (sorry it took so long to adopt)

One minor change reversal of the change to TIMESTAMP_ISO8601 (i.e. it is not getting updated) to help preserve passivity within the ingest node.

@jakelandis jakelandis merged commit 8ebff05 into elastic:master Feb 5, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019
@jasontedor
Merge branch 'master' into retention-leases-recovery
d010f37 
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelandis jakelandis jakelandis approved these changes

@talevy talevy Awaiting requested review from talevy

Assignees

No one assigned

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >enhancement v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@austintp @elasticmachine @talevy @karmi @pcsanwald @jakelandis @colings86 @ywelsch