Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale#38394
Merged
pgomulka merged 1 commit intoelastic:masterfrom Feb 5, 2019
Merged
Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale#38394pgomulka merged 1 commit intoelastic:masterfrom
pgomulka merged 1 commit intoelastic:masterfrom
Conversation
The test is now expected to be always passing no matter what the random locale is. This is fixed with using jdk ZoneId.systemDefault() in both the test and CronEvalTool closes elastic#35687
pgomulka
added
>test
Collaborator
|
Pinging @elastic/es-core-features |
astefan
requested changes
Feb 5, 2019
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
It seems you only removed the @AwaitsFix annotation..., or I'm missing something.
Contributor
Author
|
@astefan I have merged a PR where watcher module was refactored to use java-time instead of joda.time. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
|
@pgomulka apologies, but then I don't see the point of this PR... maybe refer the other PR in this one, so that I know which other PR you are talking about? |
Contributor
Author
astefan
approved these changes
Feb 5, 2019
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 5, 2019
* master: (23 commits) Lift retention lease expiration to index shard (elastic#38380) Make Ccr recovery file chunk size configurable (elastic#38370) Prevent CCR recovery from missing documents (elastic#38237) re-enables awaitsfixed datemath tests (elastic#38376) Types removal fix FullClusterRestartIT warnings (elastic#38445) Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270) Updates the grok patterns to be consistent with logstash (elastic#27181) Ignore type-removal warnings in XPackRestTestHelper (elastic#38431) testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232) add basic REST test for geohash_grid (elastic#37996) Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414) Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405) Throw AssertionError when no master (elastic#38432) `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411) Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394) Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129) SQL: Implement CURRENT_DATE (elastic#38175) Mute testReadRequestsReturnLatestMappingVersion (elastic#38438) [ML] Report index unavailable instead of waiting for lazy node (elastic#38423) Update Rollup Caps to allow unknown fields (elastic#38339) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is now expected to be always passing no matter what the random
locale is. This is fixed with using jdk ZoneId.systemDefault() in both
the test and CronEvalTool
closes #35687