HLRC: Move ML protocol classes into client ml package#33203
Merged
benwtrent merged 3 commits intoelastic:masterfrom Aug 28, 2018
Merged
Conversation
dimitris-athanasiou
added
review
v7.0.0
>refactoring
:ml
Collaborator
|
Pinging @elastic/es-core-infra |
Collaborator
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Aug 28, 2018
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Green means GO! LTGM as long the build is green.
dimitris-athanasiou
force-pushed
the
move-ml-protocol-classes-into-client-ml-package
branch
from
8f2b0c8 to
39fff7c
Compare
hub-cap
approved these changes
Aug 28, 2018
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
one Q. Ill let you decide and not block the merge. I assume tho there will be more calls to createParser in the future, so we might want to use a common deprecation handler.
| }; | ||
| } | ||
|
|
||
| private static final DeprecationHandler DEPRECATION_HANDLER = new DeprecationHandler() { |
Contributor
There was a problem hiding this comment.
is this the only use of DeprecationHandler in the code? There is an instance of this handler in the RestHighLevelClient as well, so it might make more sense to use the one there?
Contributor
Author
There was a problem hiding this comment.
It is actually the only use. Though we could reuse the one in RestHighLevelClient, it is an odd dependency direction. I am tempted to duplicate for now. If we hit another we can refactor.
benwtrent
pushed a commit
that referenced
this pull request
Aug 28, 2018
* HLRC: Move ML protocol classes into client ml package * Do not use log4j deprecation handler * JavaDoc should refer to correct Job path
dimitris-athanasiou
deleted the
move-ml-protocol-classes-into-client-ml-package
branch
dnhatn
added a commit
that referenced
this pull request
Aug 29, 2018
* master: Painless: Add Bindings (#33042) Update version after client credentials backport Fix forbidden apis on FIPS (#33202) Remote 6.x transport BWC Layer for `_shrink` (#33236) Test fix - Graph HLRC tests needed another field adding to randomisation exception list HLRC: Add ML Get Records API (#33085) [ML] Fix character set finder bug with unencodable charsets (#33234) TESTS: Fix overly long lines (#33240) Test fix - Graph HLRC test was missing field name to be excluded from randomisation logic Remove unsupported group_shard_failures parameter (#33208) Update BucketUtils#suggestShardSideQueueSize signature (#33210) Parse PEM Key files leniantly (#33173) INGEST: Add Pipeline Processor (#32473) Core: Add java time xcontent serializers (#33120) Consider multi release jars when running third party audit (#33206) Update MSI documentation (#31950) HLRC: create base timed request class (#33216) [DOCS] Fixes command page titles HLRC: Move ML protocol classes into client ml package (#33203) Scroll queries asking for rescore are considered invalid (#32918) Painless: Fix Semicolon Regression (#33212) ingest: minor - update test to include dissect (#33211) Switch remaining LLREST usage to new style Requests (#33171) HLREST: add reindex API (#32679)
dnhatn
added a commit
that referenced
this pull request
Aug 29, 2018
* 6.x: Fix forbidden apis on FIPS (#33202) HLRC: Add ML Get Records API (#33085) [ML] Fix character set finder bug with unencodable charsets (#33234) Tests fix - Graph HLRC client overly long line and syncing core’s copy of GraphExploreResponseTests taken from protocol. Related to #33231 Test fix - Graph HLRC test was missing field name to be excluded from randomisation logic Parse PEM Key files leniantly (#33173) Core: Add java time xcontent serializers (#33120) Consider multi release jars when running third party audit (#33206) Update MSI documentation (#31950) [DOCS] Fixes command page titles HLRC: Move ML protocol classes into client ml package (#33203) Painless: Fix Semicolon Regression (#33212)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.