SQL: Add protocol tests and remove jdbc_type from drivers response#37516
Merged
astefan merged 3 commits intoelastic:masterfrom Jan 16, 2019
Merged
SQL: Add protocol tests and remove jdbc_type from drivers response#37516astefan merged 3 commits intoelastic:masterfrom
astefan merged 3 commits intoelastic:masterfrom
Conversation
Remove jdbc_type element from a response in case of jdbc and odbc. Added casting to float csv test.
Collaborator
|
Pinging @elastic/es-search |
matriv
approved these changes
Jan 16, 2019
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM. Nicely done, especially the randomness of request params.
| assertQuery("SELECT 'abc123'", "'abc123'", "keyword", "abc123", 0); | ||
| } | ||
|
|
||
| public void testDates() throws IOException { |
Contributor
There was a problem hiding this comment.
Please rename it to testDateTimes
| } | ||
|
|
||
| public void testDates() throws IOException { | ||
| assertQuery("SELECT CAST('2019-01-14T12:29:25.000Z' AS DATE)", "CAST('2019-01-14T12:29:25.000Z' AS DATE)", "date", |
Contributor
There was a problem hiding this comment.
Just FYI if #37395 is merged first, change to AS DATETIME.
Contributor
Author
|
run the gradle build tests 2 |
Contributor
Author
|
run the gradle build tests 1 |
Contributor
Author
|
:-( run the gradle build tests 1 |
cshtdd
added a commit
to cshtdd/elasticsearch
that referenced
this pull request
Jan 16, 2019
* master: Deprecate _type from LeafDocLookup (elastic#37491) Allow system privilege to execute proxied actions (elastic#37508) Update Put Watch to allow unknown fields (elastic#37494) AwaitsFix testAddNewReplicas SQL: Add protocol tests and remove jdbc_type from drivers response (elastic#37516) SQL: [Docs] Add an ES-SQL column for data types (elastic#37529) IndexMetaData#mappingOrDefault doesn't need to take a type argument. (elastic#37480) Simplify + Cleanup Dead Code in Settings (elastic#37341) Reject all requests that have an unconsumed body (elastic#37504) [Ml] Prevent config snapshot failure blocking migration (elastic#37493) Fix line length for aliases and remove suppression (elastic#37455) Add SSL Configuration Library (elastic#37287) SQL: Remove slightly used meta commands (elastic#37506) Simplify Snapshot Create Request Handling (elastic#37464) Remove the use of AbstracLifecycleComponent constructor elastic#37488 (elastic#37488) [ML] log minimum diskspace setting if forecast fails due to insufficient d… (elastic#37486)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the sql protocol by running inline queries for all data types and looking directly at the response on the wire after coming back to the client. Tests are made to go through a wide range of request parameters combinations and making sure all modes are tested.
The same PR removes the
jdbc_typeelement from the response in case of jdbc/odbc.This fixes #36882 and #36635