Extend nextDoc to delegate to the wrapped doc-value iterator for date_nanos#39176
Merged
iverase merged 5 commits intoelastic:masterfrom Feb 21, 2019
Merged
Extend nextDoc to delegate to the wrapped doc-value iterator for date_nanos#39176iverase merged 5 commits intoelastic:masterfrom
iverase merged 5 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo |
jpountz
reviewed
Feb 20, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Thanks Ignacio. In addition to the integration test, can you add a unit test that the iterator supports nextDoc() in DateFieldTypeTests?
jpountz
approved these changes
Feb 20, 2019
| w.addDocument(doc); | ||
| docValuesField.setLongValue(1459641600000L); | ||
| w.addDocument(doc); | ||
| w.flush(); |
Contributor
There was a problem hiding this comment.
no need to flush, DirectoryReader.open takes care of writing NRT segments for data that only lives in the IW buffers
| .put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1).put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 1).build(); | ||
| QueryShardContext context = new QueryShardContext(0, | ||
| new IndexSettings(IndexMetaData.builder("foo").settings(indexSettings).build(), indexSettings), | ||
| null, null, null, null, null, xContentRegistry(), writableRegistry(), null, null, () -> nowInMillis, null); |
Contributor
There was a problem hiding this comment.
we don't need this object, do we?
jpountz
approved these changes
Feb 21, 2019
iverase
added a commit
that referenced
this pull request
Feb 21, 2019
…_nanos (#39176) The type date_nanos does not direct doc-value iterators and it needs to extend `next_doc` in order to delegate the call to the wrapped iterator.
iverase
added a commit
that referenced
this pull request
Feb 21, 2019
…_nanos (#39176) The type date_nanos does not direct doc-value iterators and it needs to extend `next_doc` in order to delegate the call to the wrapped iterator.
jasontedor
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2019
* elastic/master: Ensure index commit released when testing timeouts (elastic#39273) Avoid using TimeWarp in TransformIntegrationTests. (elastic#39277) Fixed missed stopping of SchedulerEngine (elastic#39193) [CI] Mute CcrRetentionLeaseIT.testRetentionLeaseIsRenewedDuringRecovery (elastic#39269) Muting AutoFollowIT.testAutoFollowManyIndices (elastic#39264) Clarify the use of sleep in CCR test Fix testCannotShrinkLeaderIndex (elastic#38529) Fix CCR tests that manipulate transport requests Align generated release notes with doc standards (elastic#39234) Mute test (elastic#39248) ReadOnlyEngine should update translog recovery state information (elastic#39238) Wrap accounting breaker check in assertBusy (elastic#39211) Simplify and Fix Synchronization in InternalTestCluster (elastic#39168) [Tests] Make testEngineGCDeletesSetting deterministic (elastic#38942) Extend nextDoc to delegate to the wrapped doc-value iterator for date_nanos (elastic#39176) Change ShardFollowTask to reuse common serialization logic (elastic#39094) Replace superfluous usage of Counter with Supplier (elastic#39048) Disable bwc tests for elastic#39094
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
…_nanos (elastic#39176) The type date_nanos does not direct doc-value iterators and it needs to extend `next_doc` in order to delegate the call to the wrapped iterator.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
…_nanos (elastic#39176) The type date_nanos does not direct doc-value iterators and it needs to extend `next_doc` in order to delegate the call to the wrapped iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type
date_nanosdoes not direct doc-value iterators and it needs to extendnext_docin order to delegate the call to the wrapped iterator.closes #39107