Avoid using TimeWarp in TransformIntegrationTests.#39277
Merged
jtibshirani merged 2 commits intoelastic:masterfrom Feb 22, 2019
Merged
Avoid using TimeWarp in TransformIntegrationTests.#39277jtibshirani merged 2 commits intoelastic:masterfrom
jtibshirani merged 2 commits intoelastic:masterfrom
Conversation
This commit makes TransformIntegrationTests into a standard integration test, as opposed to using TimeWarp, which uses the mock component ScheduleEngineTriggerMock to trigger watches. The simplification may help with flakiness we've observed TimeWarp, as in
jtibshirani
added
>test
Collaborator
|
Pinging @elastic/es-core-features |
talevy
approved these changes
Feb 22, 2019
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
direct calls to execution of the watch seem
alright to me! These tests were mocking this portion
of the integration anyways, and the test isn't interested
in testing scheduling. It is interested in transform script
execution.
Contributor
Author
|
Thank you both for the review! |
jtibshirani
added a commit
that referenced
this pull request
Feb 22, 2019
This commit makes `TransformIntegrationTests` into a standard integration test, as opposed to using `TimeWarp`, which registers the mock component `ScheduleEngineTriggerMock` to trigger watches. The simplification may help with flakiness we've observed `TimeWarp, as in #37882.
jasontedor
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 22, 2019
* elastic/master: Ensure index commit released when testing timeouts (elastic#39273) Avoid using TimeWarp in TransformIntegrationTests. (elastic#39277) Fixed missed stopping of SchedulerEngine (elastic#39193) [CI] Mute CcrRetentionLeaseIT.testRetentionLeaseIsRenewedDuringRecovery (elastic#39269) Muting AutoFollowIT.testAutoFollowManyIndices (elastic#39264) Clarify the use of sleep in CCR test Fix testCannotShrinkLeaderIndex (elastic#38529) Fix CCR tests that manipulate transport requests Align generated release notes with doc standards (elastic#39234) Mute test (elastic#39248) ReadOnlyEngine should update translog recovery state information (elastic#39238) Wrap accounting breaker check in assertBusy (elastic#39211) Simplify and Fix Synchronization in InternalTestCluster (elastic#39168) [Tests] Make testEngineGCDeletesSetting deterministic (elastic#38942) Extend nextDoc to delegate to the wrapped doc-value iterator for date_nanos (elastic#39176) Change ShardFollowTask to reuse common serialization logic (elastic#39094) Replace superfluous usage of Counter with Supplier (elastic#39048) Disable bwc tests for elastic#39094
jtibshirani
added a commit
that referenced
this pull request
Feb 22, 2019
This commit makes `TransformIntegrationTests` into a standard integration test, as opposed to using `TimeWarp`, which registers the mock component `ScheduleEngineTriggerMock` to trigger watches. The simplification may help with flakiness we've observed `TimeWarp, as in #37882.
jtibshirani
added a commit
that referenced
this pull request
Feb 22, 2019
This commit makes `TransformIntegrationTests` into a standard integration test, as opposed to using `TimeWarp`, which registers the mock component `ScheduleEngineTriggerMock` to trigger watches. The simplification may help with flakiness we've observed `TimeWarp, as in #37882.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
This commit makes `TransformIntegrationTests` into a standard integration test, as opposed to using `TimeWarp`, which registers the mock component `ScheduleEngineTriggerMock` to trigger watches. The simplification may help with flakiness we've observed `TimeWarp, as in elastic#37882.
weizijun
pushed a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 22, 2019
This commit makes `TransformIntegrationTests` into a standard integration test, as opposed to using `TimeWarp`, which registers the mock component `ScheduleEngineTriggerMock` to trigger watches. The simplification may help with flakiness we've observed `TimeWarp, as in elastic#37882.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes
TransformIntegrationTestsinto a standard integration test, asopposed to using
TimeWarp, which registers the mock componentScheduleEngineTriggerMockto trigger watches.The simplification may help with flakiness we've observed around
TimeWarp, as in#37882.