Clean up clusters between tests#41187
Merged
alpar-t merged 1 commit intoelastic:masterfrom Apr 18, 2019
Merged
Conversation
This PR adds additional cleanup when stopping the node. The data dir is excepted because it gets reused in some tests. Without this cleanup the number of working dir copies could grew to exhaust all available disk space.
alpar-t
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
rjernst
approved these changes
Apr 17, 2019
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks ok for now, but I wonder if we should not do this for the run task. I often use this as a way to quickly get a runnable built directory, going into the extracted dir to make local modifications and manually run elasticsearch.
Contributor
Author
|
I'll merge this now and look at run lather. |
alpar-t
added a commit
that referenced
this pull request
Apr 18, 2019
This PR adds additional cleanup when stopping the node. The data dir is excepted because it gets reused in some tests. Without this cleanup the number of working dir copies could grew to exhaust all available disk space.
alpar-t
added a commit
that referenced
this pull request
Apr 18, 2019
This PR adds additional cleanup when stopping the node. The data dir is excepted because it gets reused in some tests. Without this cleanup the number of working dir copies could grew to exhaust all available disk space.
alpar-t
added a commit
that referenced
this pull request
Apr 18, 2019
This PR adds additional cleanup when stopping the node. The data dir is excepted because it gets reused in some tests. Without this cleanup the number of working dir copies could grew to exhaust all available disk space.
Contributor
Author
|
@rjernst I looked at |
davidkyle
added a commit
that referenced
this pull request
Apr 25, 2019
This reverts commit 78e7f4a.
davidkyle
added a commit
that referenced
this pull request
Apr 25, 2019
This reverts commit 4712075.
davidkyle
added a commit
that referenced
this pull request
Apr 25, 2019
This reverts commit 44a0c46.
davidkyle
added a commit
that referenced
this pull request
Apr 25, 2019
This reverts commit a795069.
Member
|
This change had the the unfortunate side effect of deleting the test cluster log files which are vital for debugging tests. I reverted the change on all 4 branches master: 9efc853 Another problem is that the clean up code removes files but the directories are left intact. For example the |
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
This reverts commit 78e7f4a.
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
May 2, 2019
This reverts commit 9efc853.
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
May 2, 2019
This PR adresses the same concern as elastic#41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This PR adds additional cleanup when stopping the node. The data dir is excepted because it gets reused in some tests. Without this cleanup the number of working dir copies could grew to exhaust all available disk space.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This reverts commit 78e7f4a.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Revert "Revert "Clean up clusters between tests (elastic#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as elastic#41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional cleanup when stopping the node.
The data dir is excepted because it gets reused in some tests.
Without this cleanup the number of working dir copies could grew to
exhaust all available disk space.