Remove the jdk directory to save space on bwc tests#41743
Merged
alpar-t merged 2 commits intoelastic:masterfrom May 6, 2019
Merged
Remove the jdk directory to save space on bwc tests#41743alpar-t merged 2 commits intoelastic:masterfrom
alpar-t merged 2 commits intoelastic:masterfrom
Conversation
This reverts commit 9efc853.
This PR adresses the same concern as elastic#41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
mark-vieira
approved these changes
May 3, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Seems fine to me but it's not clear to me what was problematic about the previous solution. Was deleting all but the data directory causing issues?
Contributor
Author
|
Yes, it was blowing away the logs too. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Couldn't we just explicitly keep the log directory? |
Contributor
Author
|
Yes, the reason I decided to remove the JDK instead is that this takes us back to what we had before, instead of keeping the |
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
alpar-t
added a commit
that referenced
this pull request
May 6, 2019
* Revert "Revert "Clean up clusters between tests (#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as #41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 7, 2019
* elastic/master: (414 commits) Add tasks to build Docker build context artifacts (elastic#41819) Replace more uses of immutable map builder (elastic#41823) Force selection of calendar or fixed intervals in date histo agg (elastic#33727) Switch run task to use real distro (elastic#41590) Clarify that path_match also considers object fields. (elastic#41658) [DOCS] remove 'es.scripting.update.ctx_in_params' system property for 7.0 (elastic#41643) Clarify _doc is a permanent part of certain document APIs. (elastic#41727) Remove the jdk directory to save space on bwc tests (elastic#41743) Fix full text queries test that start with now (elastic#41854) Remove `nonApplicationWrite` from `SSLDriver` (elastic#41829) SQL: [Docs] Add example for custom bucketing with CASE (elastic#41787) Cleanup Bulk Delete Exception Logging (elastic#41693) [DOCS] Rewrite `term` query docs for new format (elastic#41498) Mute PermissionsIT#testWhen[...]ByILMPolicy (elastic#41858) ReadOnlyEngine assertion fix (elastic#41842) [ML] addresses preview bug, and adds check to PUT (elastic#41803) Fix javadoc in WrapperQueryBuilder Testsclusters use seprate configurations per version (elastic#41504) Skip explain fetch sub phase when request holds only suggestions (elastic#41739) remove unused import ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Revert "Revert "Clean up clusters between tests (elastic#41187)"" This reverts commit 9efc853. * Remove the jdk directory to save space on bwc tests This PR adresses the same concern as elastic#41187 in a different way. It removes only the JDK from the distribution once the cluster stops, so we keep the same disk space requirements as before adding the JDK. This is still a temporary measure, testclusters already deals with this by doing the equivalent of `cp -l` instead of an actual copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adresses the same concern as #41187 in a different way.
It removes only the JDK from the distribution once the cluster stops,
so we keep the same disk space requirements as before adding the JDK.
This is still a temporary measure, testclusters already deals with this
by doing the equivalent of
cp -linstead of an actual copy.