Deprecated support for delaying state recovery pending master nodes#53646
Merged
DaveCTurner merged 3 commits intoelastic:masterfrom Mar 18, 2020
Merged
Deprecated support for delaying state recovery pending master nodes#53646DaveCTurner merged 3 commits intoelastic:masterfrom
DaveCTurner merged 3 commits intoelastic:masterfrom
Conversation
DaveCTurner
added
the
:Distributed/Allocation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
DaveCTurner
requested changes
Mar 17, 2020
Member
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I suggested an alternative way to note that these are deprecated in the docs, but the code changes look good.
Member
|
@elasticmachine test this please |
Member
|
@elasticmachine update branch |
Member
|
@elasticmachine test this please |
Co-Authored-By: David Turner <david.turner@elastic.co>
Member
|
@elasticmachine test this please |
DaveCTurner
approved these changes
Mar 18, 2020
Member
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM thanks @ShawnLi1014. Do you plan to open a follow-up to remove these settings?
DaveCTurner
pushed a commit
that referenced
this pull request
Mar 18, 2020
It is useful to be able to delay state recovery until enough data nodes have joined the cluster, since this gives the shard allocator a decent opportunity to re-use as much existing data as possible. However we also have the option to delay state recovery until a certain number of master-eligible nodes have joined, and this is unnecessary: we require a majority of master-eligible nodes for state recovery, and there is no advantage in waiting for more. This commit deprecates the unnecessary settings in preparation for their removal. Relates #51806
Contributor
Author
Thank you, and yes I am working on it |
38 tasks
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 26, 2021
The `gateway.recover_after_nodes` setting is one of the lucky few that gets a mention in the default `elasticsearch.yml` config file. This setting was deprecated in favour of `gateway.recover_after_data_nodes` in elastic#53646, but neither of these settings is really important enough to warrant a place in the default config so this commit removes it.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The `gateway.recover_after_nodes` setting is one of the lucky few that gets a mention in the default `elasticsearch.yml` config file. This setting was deprecated in favour of `gateway.recover_after_data_nodes` in #53646, but neither of these settings is really important enough to warrant a place in the default config so this commit removes it.
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2021
The `gateway.recover_after_nodes` setting is one of the lucky few that gets a mention in the default `elasticsearch.yml` config file. This setting was deprecated in favour of `gateway.recover_after_data_nodes` in #53646, but neither of these settings is really important enough to warrant a place in the default config so this commit removes it.
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77951) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77952) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77953) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77958) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77954) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77956) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77955) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…) (#77957) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
jrodewig
added a commit
that referenced
this pull request
Sep 16, 2021
…) (#77959) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #51806, we now have the option to delay state recovery until a certain number of master-eligible nodes have joined, but this seems unnecessary: we require a majority of master-eligible nodes for state recovery, but there is no advantage in waiting for more.
This pull request deprecated the following settings in
GatewayService.javagateway.expected_nodesgateway.expected_master_nodesgateway.recover_after_nodesgateway.recover_after_master_nodes