Remove support for delaying state recovery pending master by ShawnLi1014 · Pull Request #53845 · elastic/elasticsearch

ShawnLi1014 · 2020-03-20T09:09:07Z

The following settings are deprecated:

gateway.expected_nodes
gateway.expected_master_nodes
gateway.recover_after_nodes
gateway.recover_after_master_nodes
This pull request removed these settings.

Closes #51806

Co-Authored-By: David Turner <david.turner@elastic.co>

elasticmachine · 2020-03-20T09:13:33Z

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

DaveCTurner · 2020-03-20T11:44:04Z

@elasticmachine test this please

DaveCTurner

Thanks @ShawnLi1014. Before I dive into the code in detail, there's a couple of points for the docs:

would you document this change in docs/reference/migration/migrate_8_0/settings.asciidoc since it's a breaking change? Note the settings that were removed and name the settings that users should use instead.
the docs themselves deserve a bit more of an overhaul, since there's now only one expected_ setting and one recover_after_. I think we can explain what they do a bit more clearly now that we don't have to account for people using some combination of all the different settings.

You can see a preview of the docs here: http://elasticsearch_53845.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/modules-gateway.html which hopefully helps.

I think an example would be useful too. See the end of docs/reference/setup/important-settings/discovery-settings.asciidoc for an example of the syntax for a YAML example with callouts to explain each part. Would you add an example?

I'll help with the details of the docs at a later date if needed.

DaveCTurner · 2020-03-20T12:05:20Z

Also note the check style failure from CI:

11:54:21 [ant:checkstyle] [ERROR] /dev/shm/elastic+elasticsearch+pull-request-1/server/src/test/java/org/elasticsearch/gateway/GatewayServiceTests.java:24:8: Unused import - org.elasticsearch.common.settings.Setting. [UnusedImports]

DaveCTurner · 2020-04-02T07:02:55Z

@ShawnLi1014 how are you getting on with addressing the review comments?

ShawnLi1014 · 2020-04-02T08:20:59Z

@ShawnLi1014 how are you getting on with addressing the review comments?

Sry for the delay. I have committed the changes, please take a look. If there's anything need to be improved please let me know

DaveCTurner · 2020-06-29T08:41:05Z

@elasticmachine ok to test

DaveCTurner · 2020-06-29T08:49:42Z

Thanks for your patience here @ShawnLi1014. I've brought this branch up to date with recent changes in master, but there are still some places where we mention gateway.recover_after_nodes in tests and these tests now fail. I've enabled CI on this PR; would you work through any failures it encounters please?

ywelsch · 2020-07-23T07:37:32Z

@ShawnLi1014 are you still interested in working on this?

This commit removes the following deprecated settings in v8: - `gateway.expected_nodes` - `gateway.expected_master_nodes` - `gateway.recover_after_nodes` - `gateway.recover_after_master_nodes` Co-authored-by: ShawnLi1014 <shawnli1014@gmail.com>

…ue#51806

DaveCTurner · 2021-02-01T17:29:02Z

I opened #68316 for the failure.

@elasticmachine please run elasticsearch-ci/1

ywelsch

LGTM

…ettings (#77042) The ability to delay cluster state recovery once a majority of master eligible nodes has joined has been removed in 8.0. This commit checks for settings that are related, and issues a deprecation info API message about it. Relates #42404 #53845

We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77951) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77952) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77953) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77958) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77954) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77956) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77955) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77957) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

…) (#77959) We deprecated the following settings in 7.7 with PR #53646: * `gateway.expected_nodes` * `gateway.expected_master_nodes` * `gateway.recover_after_nodes` * `gateway.recover_after_master_nodes` However, we didn't add a related item to the 7.7 deprecation docs. This adds the missing item. Relates to #53845.

ShawnLi1014 and others added 6 commits March 16, 2020 20:28

Deprecated support for delaying state recovery pending master nodes

2548c0d

Merge branch 'master' into issue#51806

18457e6

Apply suggestions from code review

e61c873

Co-Authored-By: David Turner <david.turner@elastic.co>

deleted support for gateway pending master nodes settings

bd4eb78

resolved conflicts

3a0c0e2

resolved conflict in doc

9ca5517

DaveCTurner added :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >breaking v8.0.0 labels Mar 20, 2020

DaveCTurner self-requested a review March 20, 2020 09:15

DaveCTurner reviewed Mar 20, 2020

View reviewed changes

ShawnLi1014 added 2 commits April 2, 2020 01:05

documented the gateway setting changes

3a9aa7a

removed unused import

a40907f

rjernst added the Team:Distributed Meta label for distributed team. label May 4, 2020

DaveCTurner self-assigned this May 14, 2020

zroll mentioned this pull request Jun 10, 2020

Remove support for delaying state recovery pending master nodes #51806

Closed

DaveCTurner added 3 commits June 29, 2020 09:05

Merge branch 'master' into issue#51806

08ff29b

Docs tweaks

dea6866

Missing ====

bf033c6

DaveCTurner added the blocker label Nov 18, 2020

DaveCTurner and others added 2 commits February 1, 2021 15:55

Remove deprecated gateway settings

ef915ac

This commit removes the following deprecated settings in v8: - `gateway.expected_nodes` - `gateway.expected_master_nodes` - `gateway.recover_after_nodes` - `gateway.recover_after_master_nodes` Co-authored-by: ShawnLi1014 <shawnli1014@gmail.com>

Merge branch 'master' into issue#51806

d4c7603

DaveCTurner added 3 commits February 1, 2021 16:01

Merge branch '2021-02-01-remove-deprecated-gateway-settings' into iss…

54c82f8

…ue#51806

Merge fix

c8089a6

Tidy up logic

2b90a2c

DaveCTurner requested a review from ywelsch February 1, 2021 18:21

Merge branch 'master' into issue#51806

a3cb265

ywelsch approved these changes Feb 3, 2021

View reviewed changes

DaveCTurner merged commit b0d185b into elastic:master Feb 3, 2021

jakelandis mentioned this pull request Feb 22, 2021

DRAFT [META] REST Compatible API V7 completeness #68905

Closed

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

masseyke mentioned this pull request Aug 9, 2021

Update Deprecation Info API checks for 8.0 #42404

Closed

80 tasks

masseyke mentioned this pull request Aug 30, 2021

Adding deprecation info API checks for delay cluster state recovery settings #77042

Merged

jrodewig mentioned this pull request Sep 15, 2021

[DOCS] Add deprecation docs for cluster recovery defer settings #77786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove support for delaying state recovery pending master#53845

Remove support for delaying state recovery pending master#53845
DaveCTurner merged 17 commits intoelastic:masterfrom
ShawnLi1014:issue#51806

ShawnLi1014 commented Mar 20, 2020 •

edited by DaveCTurner

Loading

Uh oh!

elasticmachine commented Mar 20, 2020

Uh oh!

DaveCTurner commented Mar 20, 2020

Uh oh!

DaveCTurner left a comment

Uh oh!

DaveCTurner commented Mar 20, 2020

Uh oh!

DaveCTurner commented Apr 2, 2020

Uh oh!

ShawnLi1014 commented Apr 2, 2020

Uh oh!

DaveCTurner commented Jun 29, 2020

Uh oh!

DaveCTurner commented Jun 29, 2020

Uh oh!

ywelsch commented Jul 23, 2020

Uh oh!

DaveCTurner commented Feb 1, 2021

Uh oh!

ywelsch left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ShawnLi1014 commented Mar 20, 2020 • edited by DaveCTurner Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 20, 2020

Uh oh!

DaveCTurner commented Mar 20, 2020

Uh oh!

DaveCTurner left a comment

Choose a reason for hiding this comment

Uh oh!

DaveCTurner commented Mar 20, 2020

Uh oh!

DaveCTurner commented Apr 2, 2020

Uh oh!

ShawnLi1014 commented Apr 2, 2020

Uh oh!

DaveCTurner commented Jun 29, 2020

Uh oh!

DaveCTurner commented Jun 29, 2020

Uh oh!

ywelsch commented Jul 23, 2020

Uh oh!

DaveCTurner commented Feb 1, 2021

Uh oh!

ywelsch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ShawnLi1014 commented Mar 20, 2020 •

edited by DaveCTurner

Loading