Skip to content

HLRC: UpdateByQuery API with wait_for_completion being false#58552

Merged
andreidan merged 5 commits intoelastic:masterfrom
tumile:updatebyquery-wait-for-completion
Aug 13, 2020
Merged

HLRC: UpdateByQuery API with wait_for_completion being false#58552
andreidan merged 5 commits intoelastic:masterfrom
tumile:updatebyquery-wait-for-completion

Conversation

@tumile
Copy link
Copy Markdown
Contributor

@tumile tumile commented Jun 25, 2020

Extend support for wait_for_completion=false to UpdateByQuery API by adding submitUpdateByQueryTask. Similar to prior art #35202.

Closes: #46350.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Jun 25, 2020
@andreidan andreidan self-requested a review July 2, 2020 14:49
@andreidan
Copy link
Copy Markdown
Contributor

@elasticmachine ok to test

@andreidan
Copy link
Copy Markdown
Contributor

@tumile Thank you for the contribution and sorry it took us so long to get to this. This generally looks very good 🎉

Would you mind merging master into your branch and fixing the conflict?

@tumile
Copy link
Copy Markdown
Contributor Author

tumile commented Aug 12, 2020

I'm on it 🙌

@tumile
Copy link
Copy Markdown
Contributor Author

tumile commented Aug 12, 2020

@andreidan ready for review

Copy link
Copy Markdown
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this

@andreidan andreidan merged commit 291f5bd into elastic:master Aug 13, 2020
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Aug 13, 2020
…#58552)

(cherry picked from commit 291f5bd)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit that referenced this pull request Aug 13, 2020
…#61081)

(cherry picked from commit 291f5bd)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>

Co-authored-by: Tuan Le <23419763+tumile@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shouldStoreResult is not set correctly

5 participants