Use SequentialStoredFieldsLeafReader in reading Lucene changes#67190
Merged
dnhatn merged 1 commit intoelastic:masterfrom Jan 12, 2021
Merged
Use SequentialStoredFieldsLeafReader in reading Lucene changes#67190dnhatn merged 1 commit intoelastic:masterfrom
dnhatn merged 1 commit intoelastic:masterfrom
Conversation
dnhatn
added
>enhancement
:Distributed/Engine
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
romseygeek
approved these changes
Jan 11, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to make this API a bit easier to use, but I'm going to open a separate PR to do that. Thanks @dnhatn
Member
Author
|
Thanks Alan. |
dnhatn
added a commit
that referenced
this pull request
Jan 12, 2021
Reading operations in Lucene changes is likely sequential and more efficient with SequentialStoredFieldsLeafReader. Relates #66944
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 12, 2021
…67190) Reading operations in Lucene changes is likely sequential and more efficient with SequentialStoredFieldsLeafReader. Relates elastic#66944
dnhatn
added a commit
that referenced
this pull request
Jan 12, 2021
Reading operations in Lucene changes is likely sequential and more efficient with SequentialStoredFieldsLeafReader. Relates #66944
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 5, 2021
…lastic#67190)" This reverts commit 5fe0d67.
dnhatn
added a commit
that referenced
this pull request
Feb 5, 2021
…67190)" (#68586) This reverts commit 5fe0d67. I benchmarked an improvement in CCR and found that changes introduced in #67190 made CCR 10 times slower (1816 seconds to 26515 seconds). "total_read_remote_exec_time_millis" : 2651518 "total_read_remote_exec_time_millis" : 1816094 With concurrent indexing and Lucene merges, documents in segments are no longer sorted by sequence numbers. And if the index sorting is specified, documents are never sorted by sequence numbers. Using a mergeInstance stored field reader will decompress the whole block, which we will not use. Reverts #67190
dnhatn
added a commit
that referenced
this pull request
Feb 5, 2021
…68586) Revert "Use SequentialStoredFieldsLeafReader to read Lucene changes (#67190)" (#68586) This reverts commit 5fe0d67. I benchmarked an improvement in CCR and found that changes introduced in #67190 made CCR 10 times slower (1816 seconds to 26515 seconds). "total_read_remote_exec_time_millis" : 2651518 "total_read_remote_exec_time_millis" : 1816094 With concurrent indexing and Lucene merges, documents in segments are no longer sorted by sequence numbers. And if the index sorting is specified, documents are never sorted by sequence numbers. Using a mergeInstance stored field reader will decompress the whole block, which we will not use. Reverts #67190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVERTED:
Reading operations in Lucene changes is likely sequential and more efficient with SequentialStoredFieldsLeafReader.
Relates #62509