Revert "Use SequentialStoredFieldsLeafReader to read Lucene changes"#68586
Conversation
…lastic#67190)" This reverts commit 5fe0d67.
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@dliappis Is it possible to have CCR in our nightly benchmark to catch such a kind of issue? Thanks! |
romseygeek
left a comment
There was a problem hiding this comment.
Well done catching this before it was released! Do we know if it did improve things for the specific case where sequence number order was preserved, or does that basically never happen?
@dnhatn as discussed offline, currently the bare metal infrastructure isn't ready to support such experiments that by definition require different regions, so we'll need to rely on the self service workflow for a bit I am afraid. |
|
Thanks @romseygeek + @dliappis. |
I will look into this. |
…68586) Revert "Use SequentialStoredFieldsLeafReader to read Lucene changes (#67190)" (#68586) This reverts commit 5fe0d67. I benchmarked an improvement in CCR and found that changes introduced in #67190 made CCR 10 times slower (1816 seconds to 26515 seconds). "total_read_remote_exec_time_millis" : 2651518 "total_read_remote_exec_time_millis" : 1816094 With concurrent indexing and Lucene merges, documents in segments are no longer sorted by sequence numbers. And if the index sorting is specified, documents are never sorted by sequence numbers. Using a mergeInstance stored field reader will decompress the whole block, which we will not use. Reverts #67190
I benchmarked an improvement in CCR and found that changes introduced in #67190 made CCR 10 times slower (1816 seconds to 26515 seconds).
With concurrent indexing and Lucene merges, documents in segments are no longer sorted by sequence numbers. And if the index sorting is specified, documents are never sorted by sequence numbers. Using a
mergeInstancestored field reader will decompress the whole block, which we will not use.I labelled this non-issue for an unreleased bug. I am also checking the other usages of
mergeInstancein Elasticsearch.