Better support for multiple nodes via ./gradlew run #89563
Better support for multiple nodes via ./gradlew run #89563jakelandis merged 9 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/es-delivery (Team:Delivery) |
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/RunTask.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/RunTask.java
Outdated
Show resolved
Hide resolved
mark-vieira
left a comment
There was a problem hiding this comment.
I'm confused why we don't use the same approach as for CCS, where you simply configure a test cluster with however many nodes and with whatever config you want, then just instruct the runtask to use that cluster?
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/RunTask.java
Outdated
Show resolved
Hide resolved
Indeed. I noticed that too when working on this and am testing a change to make run-ccs look like this and will likely submit a PR to use this approach for run-css. The missing piece was the cluster.restart() to update the on-disk configuration before start. |
|
@mark-vieira - ready for another round of review/discussion. thanks ! |
|
@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample |
|
@elasticsearchmachine update branch |
|
@elasticmachine update branch |
This commit makes minor changes to support multiple nodes
via ./gradlew run. The specific desired use case, where there 2 nodes
in the cluster where one is a coordinating only node is used as
the example configuration.