Skip to content

Better support for multiple nodes via ./gradlew run #89563

Merged
jakelandis merged 9 commits intoelastic:mainfrom
jakelandis:run_task_multi_node
Aug 29, 2022
Merged

Better support for multiple nodes via ./gradlew run #89563
jakelandis merged 9 commits intoelastic:mainfrom
jakelandis:run_task_multi_node

Conversation

@jakelandis
Copy link
Copy Markdown
Contributor

This commit makes minor changes to support multiple nodes
via ./gradlew run. The specific desired use case, where there 2 nodes
in the cluster where one is a coordinating only node is used as
the example configuration.

@jakelandis jakelandis added >non-issue :Delivery/Build Build or test infrastructure v8.5.0 labels Aug 23, 2022
@jakelandis jakelandis requested a review from mark-vieira August 23, 2022 22:12
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Aug 23, 2022
Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why we don't use the same approach as for CCS, where you simply configure a test cluster with however many nodes and with whatever config you want, then just instruct the runtask to use that cluster?

@jakelandis
Copy link
Copy Markdown
Contributor Author

jakelandis commented Aug 23, 2022

I'm confused why we don't use the same approach as for CCS

Indeed. I noticed that too when working on this and am testing a change to make run-ccs look like this and will likely submit a PR to use this approach for run-css. The missing piece was the cluster.restart() to update the on-disk configuration before start.

@jakelandis
Copy link
Copy Markdown
Contributor Author

@mark-vieira - ready for another round of review/discussion. thanks !

@jakelandis
Copy link
Copy Markdown
Contributor Author

@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample

@jakelandis jakelandis mentioned this pull request Aug 24, 2022
@jakelandis
Copy link
Copy Markdown
Contributor Author

@elasticsearchmachine update branch

@jakelandis
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@jakelandis jakelandis merged commit d7de930 into elastic:main Aug 29, 2022
@jakelandis jakelandis deleted the run_task_multi_node branch August 29, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants