Closed
Conversation
…lastic#89562) Ass a follow up to elastic#89234, we want to also include this system property in reproduction lines so that developers are actually enabling this setting when trying to reproduce these failures.
This reverts commit 20ed7e3.
Contributor
Author
|
closing in favor of #89711 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts the changes introduced via #89442 / 20ed7e3
and re-implements the same goals but with fewer changes. Also included in this commit
is the ability to change the proxyMode via system property and mention of this
new run task in the testing documentation.
===
While working #89563 I found a better pattern that does not require updates to the run task. I think this approach is cleaner especially for debugging.
Draft PR since this PR is based on the changes in #89563 and will need to rebase to master once that change is merged.