[EuiEmptyPrompt] Remove grow from EuiPanel#5907
Merged
cchaos merged 2 commits intoelastic:mainfrom May 18, 2022
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5907/ |
elizabetdev
approved these changes
May 18, 2022
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
Tested in Chrome. A CL entry is missing.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5907/ |
Contributor
Author
|
Flakey? Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5907/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Kibana, we're using the shared No Data View empty prompt in a lot more locations. Because EuiPanel comes with
grow=trueby default and the prop has been excluded from EuiEmptyPrompt, it's been difficult to override this behavior when the prompt is placed inflex-direction: columncontainers (which is a lot in Kibana).I couldn't think of a scenario where we'd want the prompt to grow to fill it's container's height especially since the prompt's contents are centered in itself. So I just set
grow=falsedirectly in the component.To test, you'll need to set
flex-direction: columnon a parent container.Before
After
Checklist
[ ] Checked in both light and dark modes[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Updated the Figma library counterpart