Upgrade EUI to v59.0.1 by thompsongl · Pull Request #133927 · elastic/kibana

thompsongl · 2022-06-08T17:01:48Z

Summary

eui@58.0.0 ⏩ eui@59.0.1

Added .render() calls to snapshot tests are intended to reduce the output of EUI components that use Emotion for styling. If you prefer the more verbose snapshot output in your plugin, we can remove the call.

`59.0.1`

Bug fixes

Fixed custom styles from being overridden in EuiText and EuiTextColor (#5960)
Fixed EuiCallOut from consuming all available vertical height with flex-grow (#5963)

`59.0.0`

Added a new optional cloneElement prop to EuiTextAlign and EuiTextColor (#5895)
Added all border logical properties to the logicalCSS utility (#5895)
Added euiTheme.font.familySerif (#5895)
Updated API pattern for style mixin functions (#5904)
Added isInvalid and disabled as top level props on EuiDatePickerRange (#5918)
Updated EuiDatePickerRange delimiter to a sortRight icon which is swapped for alert when isInvalid (#5918)
Updated isInvalid and disabled visual states EuiSuperDatePicker (#5918)
Added the click/keydown event as an argument to EuiSelectable/EuiSelectableTemplateSitewide's onChange prop (#5926)
Updated euiTheme.colors.lightestShade to be slightly less blue and euiTheme.colors.body to be slightly darker (#5939)
Updated euiBackgroundColor() to accept an optional method property (#5939)
Removed duplicated yarn.lock dependencies (#5947)

Bug fixes

Fixed visual indicator of invalid EuiDatePickerRange and EuiSuperDatePicker (#5918)
Fixed EuiCollapsibleNavGroup TypeScript error where title definition was being overridden by an extended div element (#5935)
Fixed EuiGlobalToastList/EuiToasts disappearing immediately when given an Infinity timeout (#5954)

Breaking changes

Renamed euiTheme.colors.subdued to euiTheme.colors.subduedText (#5895)

CSS-in-JS conversions

Converted EuiText, EuiTextAlign, and EuiTextColor, and removed their corresponding CSS modifier classes (#5895)
Partially converted EuiMarkdownFormat's text size scaling styles (#5895)
Removed $euiTextColors, euiScaleText(), and $euiTextConstrainedMaxWidth Sass utilities (#5895)
Converted EuiExpression to Emotion (#5941)

`58.1.1`

Bug fixes

Fixed EuiPopover padding by reverting removal of EuiPanel padding classes (#5927)
Updated EuiAccordion to show loading spinner instead of extra actions when isLoading (#5896)

`58.1.0`

Updated useEuiPaddingCSS() and useEuiBackgroundColorCSS() to render css blocks so consuming components render the key name in the class (#5891)
Added padding sizes xs and xl to EuiPanel (#5891)

Bug fixes

Fixed EuiSplitPanel contained border radius by setting overflow: hidden (#5891)
Fixed EuiCallOut description top margin when only child (#5891)
Fixed height stretching of EuiEmptyPrompt by setting grow=false on the nested panel (#5907)
Fixed EuiInMemoryTable's loading state from shifting layout (#5914)
Fixed accessibility errors with EuiDataGrid's column sorting drag & drop handles (#5916)
Fixed EuiMark's screen reader helpers causing scroll issues in Chrome (#5921)

CSS-in-JS conversions

Converted EuiAccordion to Emotion; Removed $paddingSizes (#5826)
Converted EuiPanel to Emotion (#5891)
Renamed euiScreenReaderOnlyStyles() mixin to euiScreenReaderOnly() (#5921)

…-ref HEAD~1..HEAD --fix'

…eui/59.0

patrykkopycinski

Asset mgt LGTM

jloleysens

LGTM, great work @thompsongl

stephmilovic

Threat hunting explore changes lgtm

justinkambic

Uptime changes LGTM

spong · 2022-06-20T19:20:01Z

...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/create/index.tsx

  const [activeStep, setActiveStep] = useState<RuleStep>(RuleStep.defineRule);
  const getNextStep = (step: RuleStep): RuleStep | undefined =>
    ruleStepsOrder[ruleStepsOrder.indexOf(step) + 1];
+  // @ts-expect-error forwardRef


Is there anything we can do here to resolve this? I see other usages of useRef with different Eui* components that don't have this error, but seems EuiAccordion surfaces this? the other components (without error) are either a class or interface it looks like, so this is a result of EuiAccordion being exported as a const and so messes with type inference in useRef then?

Yeah thanks, I meant to take another pass at this. I think we'll need to export the underlying class so that it's accessible here. That'll need to happen in a subsequent release, so I'll update the comment with an link to an EUI issue. We'll then resolve the @ts-expect-error in a future upgrade.

Comment updated in 8bc8463

spong

One question around a new // @ts-expect-error forwardRef added, but other than Security Solution Rule changes LGTM 👍

fkanout

Actionable Observability changes LGTM.

yctercero

LGTM for security-solution-platform codeowner files.

kibana-ci · 2022-06-21T21:49:47Z

💛 Build succeeded, but was flaky

Failed CI Steps

Osquery Cypress Tests

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.9MB	2.9MB	-196.0B
`cases`	352.4KB	352.3KB	-90.0B
`cloudSecurityPosture`	189.2KB	189.2KB	+4.0B
`fleet`	840.3KB	840.3KB	-62.0B
`indexLifecycleManagement`	151.5KB	151.4KB	-93.0B
`indexManagement`	515.6KB	515.6KB	-31.0B
`infra`	1009.1KB	1008.9KB	-168.0B
`maps`	2.6MB	2.6MB	-62.0B
`ml`	3.3MB	3.3MB	-58.0B
`observability`	560.2KB	560.2KB	-48.0B
`osquery`	1.0MB	1.0MB	-24.0B
`painlessLab`	16.2KB	16.1KB	-93.0B
`savedObjectsManagement`	83.7KB	83.7KB	-31.0B
`securitySolution`	5.3MB	5.3MB	-512.0B
`sessionView`	74.3KB	74.3KB	+4.0B
`spaces`	153.0KB	153.0KB	-29.0B
`synthetics`	873.0KB	872.9KB	-91.0B
`triggersActionsUi`	862.8KB	862.4KB	-372.0B
`visTypeTimeseries`	450.1KB	450.1KB	-31.0B
`visualizations`	254.1KB	254.3KB	+125.0B
total			-1.8KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	4954	4961	+7
`total size`	7.7MB	7.7MB	-12.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	46.2KB	46.2KB	+8.0B
`core`	306.3KB	306.5KB	+166.0B
`expressions`	97.1KB	97.1KB	-46.0B
`kbnUiSharedDeps-css`	567.3KB	547.7KB	-19.6KB
`kbnUiSharedDeps-npmDll`	5.0MB	5.0MB	+66.2KB
`timelines`	273.5KB	273.5KB	-72.0B
total			+46.7KB

History

💔 Build #52228 failed 467e32a
💛 Build #52197 was flaky fb16be9
💔 Build #52191 failed 035da84
💔 Build #52138 failed f9de214
💚 Build #51971 succeeded 90542eb
💛 Build #51914 was flaky 071d320

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thompsongl added 4 commits June 8, 2022 11:54

eui to v59.0.0

683910d

i18n tokens

fac0b03

update theme var tokens

3d5b008

mock mouseevent for euiselectable

8e24a82

thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI ci:deploy-cloud v8.4.0 labels Jun 8, 2022

thompsongl and others added 22 commits June 8, 2022 12:02

Merge branch 'main' into eui/59.0

a7008b9

mock mouseevent for euiselectable

d89a436

Merge branch 'main' into eui/59.0

99340c0

update theme var tokens

fe6c48d

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

4559aa7

…-ref HEAD~1..HEAD --fix'

mock mouseevent for euiselectable

200d8d2

update theme var tokens

28de439

Merge branch 'main' into eui/59.0

18b87a6

Merge branch 'eui/59.0' of https://github.com/thompsongl/kibana into …

6abe176

…eui/59.0

update theme var tokens mocks

f25122f

WIP: forwardRef type

1b3b206

Merge branch 'main' into eui/59.0

ecaede1

update snapshots

b92d092

Merge branch 'main' into eui/59.0

c2cf1c2

euiTextColor

f3e3d85

snapshot updates

14104d0

Merge branch 'main' into eui/59.0

3ac03a1

jest test updates

f15718b

euiTextColor updates

6901466

jest test updates

3e772b1

Merge branch 'main' into eui/59.0

f41d8fe

update getVisualizeError selector

d671850

patrykkopycinski approved these changes Jun 20, 2022

View reviewed changes

jloleysens approved these changes Jun 20, 2022

View reviewed changes

thompsongl added 3 commits June 20, 2022 09:20

Merge branch 'main' into eui/59.0

3cbcfc3

Merge branch 'main' into eui/59.0

45d3856

paddingSizes update

071d320

stephmilovic approved these changes Jun 20, 2022

View reviewed changes

justinkambic approved these changes Jun 20, 2022

View reviewed changes

justinkambic mentioned this pull request Jun 20, 2022

[Uptime/Synthetics] Remove UI Snapshot tests elastic/uptime#474

Open

spong reviewed Jun 20, 2022

View reviewed changes

spong approved these changes Jun 20, 2022

View reviewed changes

Merge branch 'main' into eui/59.0

90542eb

thompsongl mentioned this pull request Jun 20, 2022

[EuiAccordion] Export underlying EuiAccordionClass? elastic/eui#5985

Closed

euiaccordion class type comment

8bc8463

fkanout approved these changes Jun 21, 2022

View reviewed changes

Merge branch 'main' into eui/59.0

f9de214

yctercero approved these changes Jun 21, 2022

View reviewed changes

Merge branch 'main' into eui/59.0

6547321

kqualters-elastic approved these changes Jun 21, 2022

View reviewed changes

thompsongl added 5 commits June 21, 2022 11:23

Merge branch 'main' into eui/59.0

035da84

snapshots

8f1b656

Merge branch 'main' into eui/59.0

fb16be9

Merge branch 'main' into eui/59.0

467e32a

Merge branch 'main' into eui/59.0

2f8dd09

thompsongl merged commit 2336f33 into elastic:main Jun 21, 2022

kibanamachine added the backport:skip This PR does not require backporting label Jun 21, 2022

pgayvallet mentioned this pull request Jun 23, 2022

[Global search] No results view does not render correctly #134908

Closed

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v59.0.1#133927

Upgrade EUI to v59.0.1#133927
thompsongl merged 65 commits intoelastic:mainfrom
thompsongl:eui/59.0

thompsongl commented Jun 8, 2022 •

edited

Loading

Uh oh!

patrykkopycinski left a comment

Uh oh!

jloleysens left a comment

Uh oh!

stephmilovic left a comment

Uh oh!

justinkambic left a comment

Uh oh!

spong Jun 20, 2022

Uh oh!

thompsongl Jun 20, 2022

Uh oh!

thompsongl Jun 21, 2022

Uh oh!

spong left a comment

Uh oh!

fkanout left a comment

Uh oh!

yctercero left a comment

Uh oh!

kibana-ci commented Jun 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

thompsongl commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

59.0.1

59.0.0

58.1.1

58.1.0

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

spong Jun 20, 2022

Choose a reason for hiding this comment

Uh oh!

thompsongl Jun 20, 2022

Choose a reason for hiding this comment

Uh oh!

thompsongl Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

fkanout left a comment

Choose a reason for hiding this comment

Uh oh!

yctercero left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jun 21, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Canvas Sharable Runtime

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

thompsongl commented Jun 8, 2022 •

edited

Loading

`59.0.1`

`59.0.0`

`58.1.1`

`58.1.0`