[EuiDataGrid] Fix sorting drag handle axe errors#5916
Merged
cee-chen merged 2 commits intoelastic:mainfrom May 20, 2022
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5916/ |
1Copenut
approved these changes
May 20, 2022
Contributor
1Copenut
left a comment
1Copenut
left a comment
There was a problem hiding this comment.
LGTM. I ran it through VO + Safari to ensure no regression. The keyboard navigation works better now that there's not a nested button too.
Contributor
Author
|
Fantastic!! Thanks for everything (catching the nested props, going down a rabbit hole with me) Trevor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #5900
closes #5912
aria-labeland triggering an axe errorChecklist