Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5960/ |
…g; fix test cases with children
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5960/ |
cee-chen
reviewed
Jun 8, 2022
cee-chen
reviewed
Jun 8, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5960/ |
cee-chen
reviewed
Jun 8, 2022
| const props = { css: cssStyles, ...rest }; | ||
|
|
||
| if (cloneElement) { | ||
| if (isValidElement(children) && cloneElement) { |
Contributor
There was a problem hiding this comment.
Also forgot to mention, great catch on this!
cee-chen
reviewed
Jun 8, 2022
cee-chen
reviewed
Jun 8, 2022
cee-chen
approved these changes
Jun 8, 2022
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Thank you for the fix and tests!! 🎉 Not sure if you need to revert the docs change before merge, but otherwise LGTM
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5960/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5960/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
The new cloning mechanism doesn't respect the custom
styleattribute.The solution:
Fixed for EuiText
Checklist