[EuiBasicTable] Remove bottom border of table header cell#5914
Merged
cchaos merged 3 commits intoelastic:mainfrom May 20, 2022
Merged
[EuiBasicTable] Remove bottom border of table header cell#5914cchaos merged 3 commits intoelastic:mainfrom
cchaos merged 3 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5914/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5914/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5914/ |
cee-chen
approved these changes
May 20, 2022
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Nice catch and fix! Looks good to me on staging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4283
Removes the bottom border of table headers so that it doesn't compete with the top border of cells. Everything should render exactly as it did, but now the loading state is properly aligned.
CleanShot.2022-05-20.at.14.39.17.mp4
EuiInMemoryTable
EuiBasicTable
Empty state
Checklist
[ ] Checked in both light and dark modes[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Updated the Figma library counterpart