Skip to content

[CSS-in-JS] Convert EuiTextDiff#6056

Merged
thompsongl merged 4 commits intoelastic:mainfrom
thompsongl:css-in-js/euitextdiff
Jul 20, 2022
Merged

[CSS-in-JS] Convert EuiTextDiff#6056
thompsongl merged 4 commits intoelastic:mainfrom
thompsongl:css-in-js/euitextdiff

Conversation

@thompsongl
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl commented Jul 18, 2022

Summary

Converts EuiTextDiff to @emotion styling

Checklist

  • Checked in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_6056/

@thompsongl thompsongl marked this pull request as ready for review July 18, 2022 16:25
Copy link
Copy Markdown
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

I looked at the code and tested it in Chrome, Safari, Edge, and Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants