Upgrade EUI to v62.0.3 by cee-chen · Pull Request #138351 · elastic/kibana

cee-chen · 2022-08-09T04:52:51Z

Summary

eui@60.3.0 ⏩ eui@62.0.3

`62.0.3`

Bug fixes

Fixed EuiPortal changes causing rerender issues in test environments (#6105)

`62.0.2`

Added new React Testing Library ByDataTestSubj utilities for targeting EUI's data-test-subj attributes. These can be accessed by importing custom RTL render and screen utils from @elastic/eui/lib/test/rtl. (#6091)
Added new React Testing Library EuiPopover helpers, waitForEuiPopoverOpen and waitForEuiPopoverClose (#6091)

Bug fixes

Restored non-Emotion classNames to EuiCommentEvent's children (#6089)

`62.0.1`

Bug fixes

Fixed a bug preventing EuiPortal from working in server-side rendering (#6055)
Fixed an EuiFilterButton accessibility error (#6076)
Fixed EuiImage rendering empty captions (#6081)
Fixed EuiImage not respecting text-align on parents (#6081)

`62.0.0`

Updated EuiText.img styles to prevent images from growing full width (#5969)
Improved EuiImage's allowFullScreen screen reader experience (#5969)
Updated EuiImage's full screen mode to use the fullScreenExit icon (#5969)
Updated EuiPopover's display prop to accept any CSS display value (#5977)
Added data-popover-open attribute to EuiPopover's panel (#5977)
Changed EuiPopover's box-shadow to filter (#5977)
Added logicalSizeCSS and logicalSizeStyle for quickly producing width and height styles (#5977)
Increased the opacity of the shadow color in dark mode (#5977)
Improved screen reader accessibility for EuiDataGrid column headers (#6034)
Added tokenMetricCounter and tokenMetricGauge to EuiToken (#6064)
Removed the nested aria-label on the EuiAvatar icon to simplify a11y (#6071)
Added timelineAvatarAriaLabel to EuiComment (#6071)

Bug fixes

Reverted the change EuiCommentEvent.username type from ReactNode to string (#6071)
Fixed searchable single selection EuiSelectables not correctly highlighting the checked option on initial render (#6072)

Breaking changes

Updated EuiImage.className to be applied to the img instead of the parent wrapper figure and added wrapperProps prop so that consumers can apply props to the figure element (#5969)
Renamed EuiPopover's display prop value inlineBlock to inline-block (#5977)
EuiPopover: Removed false as an option from initialFocus (#6044)
Renamed timelineIcon on EuiComment to timelineAvatar (#6071)

CSS-in-JS conversions

Converted EuiErrorBoundary to Emotion (#6053)
Converted EuiTextDiff to Emotion (#6056)
Converted euiBreakpoint mixin to Emotion. (#6057)
Converted EuiImage to Emotion (#5969)
Converted EuiPopover, EuiPopoverTitle, EuiPopoverFooter, EuiInputPopover (#5977)

`61.0.0`

Added eventIcon, eventIconAriaLabel, and eventColor props to EuiComment (#6030)
Updated EuiComment.actions type to accept ReactNode[] (#6030)
Updated .euiMarkdownEditor display to flex to prevent display issues when the markdown editor is inside a EuiComment (#6030)
Added styles for kbd's within EuiText (#6049)
Added keyboard glyph to EuiIcon (#6058)

Bug fixes

Fixed bug in EuiTimelineItem where classNames were not being applied (#6030)
Fixed multiple missing CSS logical properties within EuiText children (#6059)

Deprecations

Deprecated EuiIcon's keyboardShortcut in favor of keyboard (#6058)

Breaking changes

Changed EuiCommentEvent.username type from ReactNode to string (#6030)
Updated EuiCommentList and EuiComment to use EuiTimeline and EuiTimelineItem respectively. This change makes the EuiCommentList to be always required (#6030)
Removed EuiComment.type (#6030)

CSS-in-JS conversions

Converted EuiComment to Emotion (#6030)

- Emotion CSS hash changed

…nversion

- see elastic/eui#6071

…d by Emotion conversions - Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct

see elastic/eui#6044

- see elastic/eui#5977

…h new `[data-popover-open]` attribute

…ver animation/transition

- test w/ similar error already skipped in another test above - requires closing the popover for next test to pass - not sure why delete action is no longer available

weltenwort

monitoring plugin changes LGTM, thank you

justinkambic

Uptime changes LGTM

rshen91

Test changes in shared-ux LGTM! thanks

jonathan-buttner · 2022-08-11T17:42:11Z

x-pack/plugins/cases/public/client/attachment_framework/types.ts

 export interface AttachmentViewObject<Props = {}> {
-  type?: EuiCommentProps['type'];
-  timelineIcon?: EuiCommentProps['timelineIcon'];
+  type?: SupportedUserActionTypes;


Reminder to myself that we need to remove this prop.

I took a peek at the alerting changes as well, and LGTM.

cee-chen · 2022-08-11T18:04:53Z

@elasticmachine merge upstream

cee-chen · 2022-08-11T19:11:33Z

@elasticmachine merge upstream

tsullivan

app services changes LGTM

Great work! Thank you!

cee-chen · 2022-08-12T16:11:13Z

Thanks everyone - have a great weekend!

cee-chen · 2022-08-12T16:11:18Z

@elasticmachine merge upstream

cee-chen · 2022-08-12T17:07:23Z

@elasticmachine merge upstream

cee-chen · 2022-08-12T18:54:30Z

@elasticmachine merge upstream

cee-chen · 2022-08-12T20:11:18Z

@elasticmachine merge upstream

cee-chen · 2022-08-12T21:31:18Z

@elasticmachine merge upstream

kibana-ci · 2022-08-12T22:38:33Z

💛 Build succeeded, but was flaky

Failed CI Steps

APM Cypress Tests

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.0MB	3.0MB	-16.0B
`canvas`	1.0MB	1.0MB	+6.0B
`cases`	358.5KB	358.4KB	-40.0B
`osquery`	1.0MB	1.0MB	-16.0B
`securitySolution`	5.4MB	5.4MB	+2.0B
`synthetics`	912.4KB	912.4KB	-12.0B
`triggersActionsUi`	1.0MB	1.0MB	+6.0B
`unifiedSearch`	233.0KB	233.0KB	+54.0B
`visDefaultEditor`	142.1KB	142.1KB	-8.0B
`visTypeTimeseries`	451.4KB	451.4KB	-16.0B
total			-40.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	349.2KB	350.5KB	+1.2KB
`kbnUiSharedDeps-css`	487.5KB	470.6KB	-16.9KB
`kbnUiSharedDeps-npmDll`	5.1MB	5.1MB	+19.7KB
`securitySolution`	254.8KB	254.7KB	-30.0B
`unifiedSearch`	46.8KB	46.8KB	+5.0B
total			+4.0KB

History

💔 Build #64924 failed d9941d3
💔 Build #64908 failed 93fd826
💔 Build #64871 failed 17c6dda
💚 Build #64639 succeeded a25f913
💔 Build #64622 failed 1769db7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Upgrade to v62.0.3 * Update EUI i18n tokens * Update html string snapshots - Emotion CSS hash changed * [EuiIcon] Update instances of `keyboardShortcut` icons to `keyboard` * [EuiErrorBoundary] Update snapshots from Emotion conversion * [EuiImage] Update snapshots, tests, and CSS to account for Emotion conversion * [EuiImage][RTL] Fix test failures caused by EuiImage changes * [EuiCommentList] Deprecate EuiCommentProps.type * [EuiCommentList] Rename `timelineIcon` prop to `timelineAvatar` - see elastic/eui#6071 * [EuiCommentList] Fix selectors deprecated by Emotion conversion * [EuiPopover][EuiCommentEvent][Enzyme] Fix mounted test failures caused by Emotion conversions - Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct * [EuiPopover] Deprecate `initialFocus={false}` as an option see elastic/eui#6044 * [EuiPopover] Rename `display=inlineBlock` to `inline-block` - see elastic/eui#5977 * [EuiPopover] Update snapshots from Emotion conversion * [EuiPopover] Replace deprecated `.euiPopover__panel-isOpen` class with new `[data-popover-open]` attribute * [EuiPopover][RTL] Fix test failures caused by not waiting for EuiPopover animation/transition * Skip failing a11y tests - test w/ similar error already skipped in another test above - requires closing the popover for next test to pass - not sure why delete action is no longer available * Fix failing Security Cypress tests * Attempt to squash flaky FTR tests around Add Filter popover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jonathan Budzenski <jon@elastic.co>

cee-chen added 19 commits August 9, 2022 08:24

Upgrade to v62.0.3

38750e0

Update EUI i18n tokens

a0b0dd5

Update html string snapshots

5001fed

- Emotion CSS hash changed

[EuiIcon] Update instances of keyboardShortcut icons to keyboard

2683608

[EuiErrorBoundary] Update snapshots from Emotion conversion

1b8e1ee

[EuiImage] Update snapshots, tests, and CSS to account for Emotion co…

9b8a6c8

…nversion

[EuiImage][RTL] Fix test failures caused by EuiImage changes

ad5dd7d

[EuiCommentList] Deprecate EuiCommentProps.type

01f66e8

[EuiCommentList] Rename timelineIcon prop to timelineAvatar

4053c1e

- see elastic/eui#6071

[EuiCommentList] Fix selectors deprecated by Emotion conversion

3ab748c

[EuiPopover][EuiCommentEvent][Enzyme] Fix mounted test failures cause…

d296c4e

…d by Emotion conversions - Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct

[EuiPopover] Deprecate initialFocus={false} as an option

7a37266

see elastic/eui#6044

[EuiPopover] Rename display=inlineBlock to inline-block

c2ce0d9

- see elastic/eui#5977

[EuiPopover] Update snapshots from Emotion conversion

e4ea528

[EuiPopover] Replace deprecated .euiPopover__panel-isOpen class wit…

b8291bd

…h new `[data-popover-open]` attribute

[EuiPopover][RTL] Fix test failures caused by not waiting for EuiPopo…

cc29eb8

…ver animation/transition

Skip failing a11y tests

1667551

- test w/ similar error already skipped in another test above - requires closing the popover for next test to pass - not sure why delete action is no longer available

Fix failing Security Cypress tests

426230d

Attempt to squash flaky FTR tests around Add Filter popover

9c28689

cee-chen force-pushed the eui/62.0.3 branch from 796a044 to 9c28689 Compare August 9, 2022 15:24

cee-chen changed the title ~~[Test]~~ Upgrade EUI to v62.0.3 Aug 9, 2022

cee-chen mentioned this pull request Aug 9, 2022

Upgrade EUI to v62.0.3 #136865

Closed

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.5.0 labels Aug 9, 2022

cee-chen marked this pull request as ready for review August 9, 2022 16:43

cee-chen requested a review from a team August 9, 2022 16:43

cee-chen requested review from a team as code owners August 9, 2022 16:43

cee-chen requested a review from a team August 9, 2022 16:43

weltenwort self-requested a review August 11, 2022 09:27

weltenwort approved these changes Aug 11, 2022

View reviewed changes

justinkambic approved these changes Aug 11, 2022

View reviewed changes

rshen91 approved these changes Aug 11, 2022

View reviewed changes

yctercero approved these changes Aug 11, 2022

View reviewed changes

jonathan-buttner approved these changes Aug 11, 2022

View reviewed changes

Merge branch 'main' into eui/62.0.3

1769db7

Merge branch 'main' into eui/62.0.3

a25f913

jonathan-buttner mentioned this pull request Aug 11, 2022

[ResponseOps][Cases] Removing type field from attachment framework #138676

Merged

Merge branch 'main' into eui/62.0.3

17c6dda

mdefazio approved these changes Aug 12, 2022

View reviewed changes

tsullivan approved these changes Aug 12, 2022

View reviewed changes

Merge branch 'main' into eui/62.0.3

5f203b9

Merge branch 'main' into eui/62.0.3

d21883e

Merge branch 'main' into eui/62.0.3

93fd826

Merge branch 'main' into eui/62.0.3

d9941d3

Merge branch 'main' into eui/62.0.3

16efc6e

cee-chen merged commit 7b11420 into elastic:main Aug 12, 2022

cee-chen deleted the eui/62.0.3 branch August 12, 2022 23:40

kibanamachine added the backport:skip This PR does not require backporting label Aug 12, 2022

Conversation

cee-chen commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

62.0.3

62.0.2

62.0.1

62.0.0

61.0.0

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

rshen91 left a comment

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

pmuellr Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Aug 11, 2022

Uh oh!

cee-chen commented Aug 11, 2022

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

cee-chen commented Aug 12, 2022

Uh oh!

kibana-ci commented Aug 12, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

cee-chen commented Aug 9, 2022 •

edited

Loading

`62.0.3`

`62.0.2`

`62.0.1`

`62.0.0`

`61.0.0`