Update docs with the addition of filter editors#12321
Merged
lukasolson merged 2 commits intoelastic:masterfrom Jun 22, 2017
Merged
Update docs with the addition of filter editors#12321lukasolson merged 2 commits intoelastic:masterfrom
lukasolson merged 2 commits intoelastic:masterfrom
Conversation
alexfrancoeur
approved these changes
Jun 16, 2017
alexfrancoeur
left a comment
alexfrancoeur
left a comment
There was a problem hiding this comment.
LGTM. Added a minor comment for the operators but it's just a suggestion. The content and images look good.
docs/discover/field-filter.asciidoc
Outdated
| particular value by selecting *is*, where a filter doesn't match a particular | ||
| value by selecting *is not*, where a field is present (*exists*), or where a | ||
| value for a field is within a range (*is between*). In addition, you can filter | ||
| where a field *is one of* a particular list of values. |
There was a problem hiding this comment.
Would this list be better represented as a table? Explicitly describing exactly how each operator works. It might be overkill, but at least we're not missing anything. There are 6 different operators. I added something similar here for the options available in Timelion
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jun 22, 2017
* Update docs with the addition of filter editors * Move operators into a table
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jun 22, 2017
* Update docs with the addition of filter editors * Move operators into a table
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the docs since the addition of filter editors.