[ML] Adding cloud specific ML node warning by jgowdyelastic · Pull Request #50139 · elastic/kibana

jgowdyelastic · 2019-11-11T10:40:20Z

Adds a link to the cloud deployment when there are no nodes and kibana is running on cloud.

Text in callout

No ML nodes available
There are no ML nodes available.
You will not be able to create or run jobs.
Please edit your Elastic Cloud deployment and enable a machine learning node.

Can be tested by adding some settings to yml files:
elasticsearch.yml
node.ml: false

kibana.yml
xpack.cloud.id: <supply your own cloud id>

Also moves some code about:
Due to issues in the kibana CI, there some planned refactoring has not made it into this PR.
In a follow up PR, new_job_defaults.ts will be removed in favour of a dedicated ml_server_info service.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-11-11T10:40:22Z

Pinging @elastic/ml-ui (:ml)

jgowdyelastic · 2019-11-11T11:56:55Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T11:57:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 554fef7

jgowdyelastic · 2019-11-11T12:30:14Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T13:48:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3b71612

…b.com:jgowdyelastic/kibana into adding-cloud-specific-ml-node-warning-callout

jgowdyelastic · 2019-11-11T15:14:00Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T15:51:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d0d5f91

jgowdyelastic · 2019-11-11T15:54:46Z

retest

jgowdyelastic · 2019-11-11T16:00:50Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T16:19:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7172372

poffdeluxe · 2019-11-11T16:29:54Z

Hey there I was lookin into some of the test failures on this PR and noticed that whenever I try to access Kibana with this branch, I get an invalid regexp group syntax error. I believe it's related to this line: https://github.com/elastic/kibana/pull/50139/files#diff-7f047fa49a76cb2de3819ba4e6cbf3dfR73

…b.com:jgowdyelastic/kibana into adding-cloud-specific-ml-node-warning-callout

jgowdyelastic · 2019-11-11T16:46:49Z

thanks @poffdeluxe, looks like the regex was the issue.
Thanks for looking into it, it's quite strange it would be reported as a canvas test error.

peteharverson

Tested, and LGTM

elasticmachine · 2019-11-11T18:14:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 12f27a5

jgowdyelastic · 2019-11-11T18:19:49Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T19:30:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5087302

jgowdyelastic · 2019-11-11T20:23:57Z

retest

elasticmachine · 2019-11-11T21:36:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5087302

darnautov

LGTM, some nit comments

darnautov · 2019-11-12T08:01:12Z

...lugins/ml/public/jobs/jobs_list/components/node_available_warning/node_available_warning.tsx

+export const NodeAvailableWarning: FC = () => {
+  if (mlNodesAvailable() === true || permissionToViewMlNodeCount() === false) {
+    return null;
+  } else {


nit: else is redundant

darnautov · 2019-11-12T08:05:21Z

x-pack/legacy/plugins/ml/public/jobs/new_job_new/utils/new_job_defaults.ts

+  return cloudInfo.isCloud;
+}
+
+export function cloudDeploymentId(): string | null {


nit: getCloudDeploymentId would be more descriptive

darnautov · 2019-11-12T08:06:31Z

x-pack/legacy/plugins/ml/server/routes/system.js

+
+      try {
+        const info = await callWithRequest('ml.info');
+        const cloudIdKey = 'xpack.cloud.id';


nit: would be convenient to have a dictionary for such constants

walterra

LGTM

jgowdyelastic · 2019-11-12T09:03:07Z

The comments raised will be addressed in a post 7.5 follow up PR which will also reintroduce the refactoring which was removed from original PR.

* [ML] Adding cloud specific ML node warning * fixing include * adding callout and cloud checks * fixing translations * removing positive look behind in regex

* upstream/master: [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)

* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)

…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)

[ML] Adding cloud specific ML node warning

554fef7

jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes labels Nov 11, 2019

jgowdyelastic requested a review from a team as a code owner November 11, 2019 10:40

fixing include

b47f616

jgowdyelastic added v7.5.0 v7.6.0 v8.0.0 labels Nov 11, 2019

Merge branch 'master' into adding-cloud-specific-ml-node-warning-callout

550d2a2

Merge branch 'master' into adding-cloud-specific-ml-node-warning-callout

3b71612

jgowdyelastic added 3 commits November 11, 2019 13:57

adding callout and cloud checks

451edf6

Merge branch 'adding-cloud-specific-ml-node-warning-callout' of githu…

1d37b4c

…b.com:jgowdyelastic/kibana into adding-cloud-specific-ml-node-warning-callout

fixing translations

d0d5f91

Merge branch 'master' into adding-cloud-specific-ml-node-warning-callout

7172372

Merge branch 'master' into adding-cloud-specific-ml-node-warning-callout

47f5fb8

jgowdyelastic added 2 commits November 11, 2019 16:44

removing positive look behind in regex

7555757

Merge branch 'adding-cloud-specific-ml-node-warning-callout' of githu…

d55e11d

…b.com:jgowdyelastic/kibana into adding-cloud-specific-ml-node-warning-callout

jgowdyelastic requested review from alvarezmelissa87, darnautov, peteharverson and walterra November 11, 2019 17:20

peteharverson approved these changes Nov 11, 2019

View reviewed changes

jgowdyelastic self-assigned this Nov 11, 2019

Merge branch 'master' into adding-cloud-specific-ml-node-warning-callout

5087302

darnautov approved these changes Nov 12, 2019

View reviewed changes

walterra approved these changes Nov 12, 2019

View reviewed changes

jgowdyelastic merged commit 0e3237e into elastic:master Nov 12, 2019

jgowdyelastic deleted the adding-cloud-specific-ml-node-warning-callout branch November 12, 2019 09:03

jgowdyelastic mentioned this pull request Nov 12, 2019

[7.x] [ML] Adding cloud specific ML node warning (#50139) #50281

Merged

jgowdyelastic mentioned this pull request Nov 12, 2019

[7.5] [ML] Adding cloud specific ML node warning (#50139) #50282

Merged

jgowdyelastic mentioned this pull request Nov 12, 2019

[ML] Server info service refactor #50302

Merged

3 tasks

pheyos mentioned this pull request Nov 15, 2019

[ML] Display no ML node warning on overview and analytics pages #50761

Closed

peteharverson mentioned this pull request Nov 28, 2019

[ML] Add Cloud specific error messages #35217

Closed

Conversation

jgowdyelastic commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 11, 2019

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

poffdeluxe commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

jgowdyelastic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

darnautov Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

darnautov Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic commented Nov 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jgowdyelastic commented Nov 11, 2019 •

edited

Loading

poffdeluxe commented Nov 11, 2019 •

edited

Loading