[ML] Indicate missing required privileges for import in File Data Visualizer#50147
Merged
darnautov merged 3 commits intoelastic:masterfrom Nov 11, 2019
Merged
Conversation
darnautov
added
release_note:enhancement
:ml
v8.0.0
Feature:File and Index Data Viz
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💔 Build Failed
|
jgowdyelastic
approved these changes
Nov 11, 2019
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added a couple of comments but generally LGTM
...plugins/ml/public/datavisualizer/file_based/components/file_datavisualizer_view/constants.ts
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
IMO do not reads better than don't
You do not have the privileges required to import data
Contributor
Author
There was a problem hiding this comment.
I was following https://elastic.github.io/eui/#/guidelines/writing, Use contractions section. But ok with do not as well
...acy/plugins/ml/public/datavisualizer/file_based/components/file_datavisualizer_view/index.js
Outdated
Show resolved
Hide resolved
darnautov
force-pushed
the
ML-47516-file-data-viz-indicate-privileges
branch
from
d570861 to
3df5ebf
Compare
Contributor
💚 Build Succeeded
|
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Nov 11, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested, including IE11, and LGTM
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Nov 11, 2019
…elastic#50147) * [ML] show a tooltip which indicates missing required privileges for data import * [ML] fix export * [ML] PR comments
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
lcawl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #47516. Show the tooltip in case the required privileges for import are missing.
Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenarios