[Uptime] Fix race on overview page query#67843
Merged
andrewvc merged 9 commits intoelastic:masterfrom Jun 9, 2020
Merged
Conversation
Fixes elastic#67842 by requerying during the refine phase to see if a newer matching doc has come in.
andrewvc
added
bug
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
reviewed
Jun 5, 2020
| }, | ||
| }, | ||
| latestMatching: { | ||
| '@timestamp': '2020-06-04T12:39:54.698-0500', |
Contributor
There was a problem hiding this comment.
shouldn't you try increasing the timestamp of latestMatching to cover the use case?
Contributor
Author
There was a problem hiding this comment.
I kept this case and added one for a future 'latest' timestamp
shahzad31
reviewed
Jun 5, 2020
x-pack/plugins/uptime/server/lib/requests/search/refine_potential_matches.ts
Show resolved
Hide resolved
shahzad31
reviewed
Jun 5, 2020
x-pack/plugins/uptime/server/lib/requests/search/refine_potential_matches.ts
Show resolved
Hide resolved
shahzad31
reviewed
Jun 5, 2020
| const url = getBaseUrl(dateRangeStart, dateRangeEnd) + `&filters=${filters}`; | ||
| const apiResponse = await supertest.get(url); | ||
| const nonSummaryRes = apiResponse.body; | ||
| // expect(JSON.stringify(nonSummaryRes)).to.eql("foo"); |
Contributor
There was a problem hiding this comment.
if it's not applicable anymore, it's better to remove it.
Contributor
Author
There was a problem hiding this comment.
My mistake, left over from debugging!
shahzad31
requested changes
Jun 5, 2020
Contributor
shahzad31
left a comment
shahzad31
left a comment
There was a problem hiding this comment.
It generates error when you select location in filters
Contributor
Author
|
@shahzad31 I believe I've addressed all feedback here. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jun 9, 2020
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jun 9, 2020
Fixes elastic#67842 by requerying during the refine phase to see if a newer matching doc has come in.
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Jun 9, 2020
Fixes elastic#67842 by requerying during the refine phase to see if a newer matching doc has come in.
andrewvc
added a commit
that referenced
this pull request
Jun 10, 2020
andrewvc
added a commit
that referenced
this pull request
Jun 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67842 by re-querying during the refine phase to see if a newer matching doc has come in. This also simplifies the first 'potential' phase to only return monitor IDs. Getting the top check groups is no longer necessary since we determine this value in the 'refine' phase now.
Checklist
Delete any items that are not applicable to this PR.