[ML] DF Analytics: Creation wizard part 2#68462
Merged
alvarezmelissa87 merged 5 commits intoelastic:masterfrom Jun 9, 2020
Merged
[ML] DF Analytics: Creation wizard part 2#68462alvarezmelissa87 merged 5 commits intoelastic:masterfrom
alvarezmelissa87 merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Jun 8, 2020
Contributor
walterra
left a comment
There was a problem hiding this comment.
Code looks good, just added two small comments. I'll also do a local test and will report back :)
Comment on lines
404
to
406
Contributor
There was a problem hiding this comment.
Maybe we can useHistory and history.push() here?
Contributor
There was a problem hiding this comment.
Nitty Nit: Maybe toCamelCase is a better name.
Member
60bdc72 to
ffadb39
Compare
60 tasks
walterra
approved these changes
Jun 9, 2020
Contributor
Author
|
retest |
6b126ab to
75335c1
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/fleet/setup·ts.apis Fleet Endpoints fleet_setup should create a fleet_enroll user and roleStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jun 9, 2020
* Add ability to clone job * remove deprecated creation form code * ensure excludes cloned correctly and update clone action jest test * remove unused translations * update helper function name
alvarezmelissa87
added a commit
that referenced
this pull request
Jun 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #66661
This is a follow up PR for switching over to the new creation wizard.
This PR ensures job cloning works with the new wizard and removes deprecated code for old creation flyout.
Upcoming follow-ups:
Checklist
Delete any items that are not applicable to this PR.