Skip to content

allow others to update URL.revokeObjectURL property if needed #73639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshustov merged 3 commits into from
Jul 29, 2020
Merged

allow others to update URL.revokeObjectURL property if needed #73639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb578aa
allow others to update `URL.revokeObjectURL` property if needed
spalger Jul 29, 2020
bc7b2e5
Merge branch 'master' into fix/stupid-globals
elasticmachine Jul 29, 2020
d17211c
Merge branch 'master' into fix/stupid-globals
elasticmachine Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion x-pack/plugins/reporting/public/panel_actions/get_csv_panel_action.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ describe('GetCsvReportPanelAction', () => {

beforeAll(() => {
if (typeof window.URL.revokeObjectURL === 'undefined') {
Object.defineProperty(window.URL, 'revokeObjectURL', { value: () => {} });
Object.defineProperty(window.URL, 'revokeObjectURL', {
configurable: true,
writable: true,
value: () => {},
});
}
});

Expand Down
2 changes: 1 addition & 1 deletion ...solution/public/detections/components/value_lists_management_modal/auto_download.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import { AutoDownload } from './auto_download';

describe('AutoDownload', () => {
beforeEach(() => {
// our DOM environment lacks this function that our component needs
Object.defineProperty(globalNode.window.URL, 'revokeObjectURL', {
configurable: true,
writable: true,
value: jest.fn(),
});
Expand Down