Skip to content

allow others to update URL.revokeObjectURL property if needed#73639

Merged
mshustov merged 3 commits intoelastic:masterfrom
spalger:fix/stupid-globals
Jul 29, 2020
Merged

allow others to update URL.revokeObjectURL property if needed#73639
mshustov merged 3 commits intoelastic:masterfrom
spalger:fix/stupid-globals

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Jul 29, 2020 •
edited
Loading

Fixes #73630
Fixes #73631

#73532 added a stub revokeObjectURL implementation as recommended in places like jsdom/jsdom#1721 (comment), this seems to cause a race condition if some Jest workers are running faster than others and the tests in x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal/auto_download.test.tsx execute first in the same worker that x-pack/plugins/reporting/public/panel_actions/get_csv_panel_action.test.ts executes in later.

This seems to have caused the failure in https://kibana-ci.elastic.co/job/elastic+kibana+master/7002/ but the tests passed in https://kibana-ci.elastic.co/job/elastic+kibana+master/7003/ but we don't have any visibility into the workers that tests are assigned to.

Based on my reading of JestRuntime#teardown() and JestRuntime#resetModules() it doesn't seem that window.URL is reset between tests so this somewhat unproven theory seems to make sense.

@spalger spalger requested review from a team as code owners July 29, 2020 08:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 29, 2020

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 29, 2020

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@rylnd rylnd mentioned this pull request Jul 29, 2020
Closed
2 tasks
@mshustov
Copy link
Copy Markdown
Contributor

mshustov commented Jul 29, 2020

@elasticmachine merge upstream

@mshustov
Copy link
Copy Markdown
Contributor

mshustov commented Jul 29, 2020

The Check core API changes failure has been fixed in #73650

@mshustov
Copy link
Copy Markdown
Contributor

mshustov commented Jul 29, 2020

@elasticmachine merge upstream

mistic
mistic approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 35d4bc6 into elastic:master Jul 29, 2020
mshustov pushed a commit to mshustov/kibana that referenced this pull request Jul 29, 2020
@spalger @elasticmachine @mshustov
allow others to update URL.revokeObjectURL property if needed (elas…
295d785 
…tic#73639)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mshustov mshustov mentioned this pull request Jul 29, 2020
Merged
@mistic mistic mentioned this pull request Jul 29, 2020
Closed
mistic pushed a commit to mistic/kibana that referenced this pull request Jul 29, 2020
@spalger @elasticmachine @mistic
allow others to update URL.revokeObjectURL property if needed (elas…
ab5096b 
…tic#73639)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mistic mistic mentioned this pull request Jul 29, 2020
Merged
mistic pushed a commit to mistic/kibana that referenced this pull request Jul 29, 2020
@spalger @elasticmachine @mistic
allow others to update URL.revokeObjectURL property if needed (elas…
51fca35 
…tic#73639)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Jul 29, 2020 •
edited
Loading

7.x: 4ee5497
7.9: 93f8ffa

mshustov added a commit that referenced this pull request Jul 29, 2020
@mshustov @spalger @elasticmachine
allow others to update URL.revokeObjectURL property if needed (#73639…
4ee5497 
…) (#73661)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
mistic added a commit that referenced this pull request Jul 29, 2020
@mistic @spalger @elasticmachine
allow others to update URL.revokeObjectURL property if needed (#73639…
93f8ffa 
…) (#73664)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
@spalger spalger deleted the fix/stupid-globals branch August 18, 2020 18:02
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

@sophiec20 sophiec20 added the zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Milestone

No milestone

8 participants

@spalger @elasticmachine @mshustov @kibanamachine @mistic @andrew-goldstein @MindyRS @sophiec20