Skip to content

[ML] Fixing old _xpack style es endpoint paths#73667

Merged
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fix-old-_xpack-style-es-endpoints
Jul 29, 2020
Merged

[ML] Fixing old _xpack style es endpoint paths#73667
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fix-old-_xpack-style-es-endpoints

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Jul 29, 2020 •
edited
Loading

Some deprecated elasticsearch paths where still being used in our js client.
These have recently been broken by the merging of elastic/elasticsearch#59870

@jgowdyelastic jgowdyelastic marked this pull request as ready for review July 29, 2020 14:02
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 29, 2020 14:02
@jgowdyelastic jgowdyelastic self-assigned this Jul 29, 2020
@jgowdyelastic jgowdyelastic added 7.9.0 :ml bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0 labels Jul 29, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 29, 2020

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added 7.9.0 and removed 7.9.0 labels Jul 29, 2020
peteharverson
peteharverson approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic requested a review from qn895 July 29, 2020 14:42
alvarezmelissa87
alvarezmelissa87 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 1b4d4d8 into elastic:master Jul 29, 2020
@jgowdyelastic jgowdyelastic deleted the fix-old-_xpack-style-es-endpoints branch July 29, 2020 15:44
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 29, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 29, 2020
@jgowdyelastic
[ML] Fixing old _xpack style es endpoint paths (elastic#73667)
a7a6839 
* [ML] Fixing old _xpack style es endpoint paths

* test comment

* removing test comment
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 29, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 29, 2020
@jgowdyelastic
[ML] Fixing old _xpack style es endpoint paths (elastic#73667)
866a04b 
* [ML] Fixing old _xpack style es endpoint paths

* test comment

* removing test comment
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
jgowdyelastic added a commit that referenced this pull request Jul 29, 2020
@jgowdyelastic @elasticmachine
[ML] Fixing old _xpack style es endpoint paths (#73667) (#73693)
8bb122f 
* [ML] Fixing old _xpack style es endpoint paths

* test comment

* removing test comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic added a commit that referenced this pull request Jul 29, 2020
@jgowdyelastic
[ML] Fixing old _xpack style es endpoint paths (#73667) (#73694)
15790ca 
* [ML] Fixing old _xpack style es endpoint paths

* test comment

* removing test comment
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

@qn895 qn895 Awaiting requested review from qn895

Assignees

@jgowdyelastic jgowdyelastic

Labels

bug Fixes for quality problems that affect the customer experience :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson