[Security Solution] Do not render descriptionless actions within an EuiCard by rylnd · Pull Request #73611 · elastic/kibana

rylnd · 2020-07-29T02:58:31Z

Summary

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

The more complicated Prompts (as shown in #73050) remain unchanged.

Simple prompt before:

Simple prompt after:

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

elasticmachine · 2020-07-29T03:05:56Z

Pinging @elastic/siem (Team:SIEM)

spong · 2020-07-29T03:12:03Z

x-pack/plugins/security_solution/public/common/components/empty_page/index.tsx

+                  title={descriptionTitle ?? false}
+                  description={description ?? false}


Close enough... 😅

Suggested change

title={descriptionTitle ?? false}

description={description ?? false}

gpt3={`if text === '' DON'T DISPLAY BOX AROUND BUTTON PLZ`}

spong

LGTM! Thanks for this follow-up fix and test updates @rylnd! 🚀🚀🚀

kibanamachine · 2020-07-29T04:42:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e36bbd5

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	-46.0B	7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

) This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

* master: (126 commits) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532) [Security Solution][Resolver] Handle disabled process collection (elastic#73592) [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530) [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349) ...

…ibana into actions/webhook-remove-header * 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485) [Maps] fix fit to data for Point to Point layer (elastic#73563) [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) ...

elasticmachine · 2021-09-23T14:28:41Z

Pinging @elastic/security-solution (Team: SecuritySolution)

Do not render descriptionless actions within an EuiCard

e36bbd5

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 29, 2020

rylnd self-assigned this Jul 29, 2020

rylnd marked this pull request as ready for review July 29, 2020 03:05

rylnd requested review from a team as code owners July 29, 2020 03:05

spong reviewed Jul 29, 2020

View reviewed changes

spong approved these changes Jul 29, 2020

View reviewed changes

rylnd merged commit 4cc87e3 into elastic:master Jul 29, 2020

rylnd deleted the fix-empty-page-logic branch July 29, 2020 04:59

rylnd added a commit to rylnd/kibana that referenced this pull request Jul 29, 2020

Do not render descriptionless actions within an EuiCard (elastic#73611)

4ff71e2

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

rylnd mentioned this pull request Jul 29, 2020

[7.x] Do not render descriptionless actions within an EuiCard (#73611) #73624

Merged

rylnd added a commit to rylnd/kibana that referenced this pull request Jul 29, 2020

Do not render descriptionless actions within an EuiCard (elastic#73611)

110a97f

This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

rylnd mentioned this pull request Jul 29, 2020

[7.9] Do not render descriptionless actions within an EuiCard (#73611) #73625

Merged

rylnd added a commit that referenced this pull request Jul 29, 2020

Do not render descriptionless actions within an EuiCard (#73611) (#73624

62e8e98

) This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

rylnd added a commit that referenced this pull request Jul 29, 2020

Do not render descriptionless actions within an EuiCard (#73611) (#73625

3c2f1b1

) This updates the logic of EmptyPage to better handle these cases. Adds snapshot tests to verify.

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Do not render descriptionless actions within an EuiCard#73611

[Security Solution] Do not render descriptionless actions within an EuiCard#73611
rylnd merged 1 commit intoelastic:masterfrom
rylnd:fix-empty-page-logic

rylnd commented Jul 29, 2020

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

spong Jul 29, 2020

Uh oh!

spong left a comment

Uh oh!

kibanamachine commented Jul 29, 2020

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		title={descriptionTitle ?? false}
		description={description ?? false}

	title={descriptionTitle ?? false}
	description={description ?? false}
	gpt3={`if text === '' DON'T DISPLAY BOX AROUND BUTTON PLZ`}

Conversation

rylnd commented Jul 29, 2020

Summary

Simple prompt before:

Simple prompt after:

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

spong Jul 29, 2020

Choose a reason for hiding this comment

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

async chunks size

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants