Skip to content

[kbn-storybook] Update Storybook to 5.3.19#73320

Merged
clintandrewhall merged 10 commits intoelastic:masterfrom
clintandrewhall:storybook-5.3
Jul 29, 2020
Merged

[kbn-storybook] Update Storybook to 5.3.19#73320
clintandrewhall merged 10 commits intoelastic:masterfrom
clintandrewhall:storybook-5.3

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Jul 27, 2020 •
edited
Loading

Summary

This PR updates Storybook dependencies to the latest version: 5.3.19 While the migration guide indicates all changes are "soft-deprecated", I still tested the storybooks in https://github.com/elastic/kibana/blob/master/src/dev/storybook/aliases.ts#L21-L29 for compatibility.

Next steps will be to introduce some of the changes from #73227 to make it easier for Canvas to migrate, (and hopefully make kbn-storybook more flexible, as well).

Impact to ML

The file chart_tooltip.tsx uses the react-popper-tooltip component. While Kibana's dependency on it is set for 2.8.3, the ultimate version that is installed, 2.11.1, has a slight difference to the Ref type: it can be an object as well as a function.

As a result, I've added a check for function to resolve the type issue. I'm not sure how to find my way to testing this change, but it should be benign. Regardless, this needs a review by someone from ML. Thanks!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 27, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

spalger
spalger approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please install editorconfig in your editor and update the package.json files to not include the final newlines.

@clintandrewhall clintandrewhall added the release_note:skip Skip the PR/issue when compiling release notes label Jul 27, 2020
@clintandrewhall
Copy link
Copy Markdown
Contributor Author

clintandrewhall commented Jul 28, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2020

merge conflict between base and head

@clintandrewhall clintandrewhall requested a review from a team as a code owner July 28, 2020 20:44
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 28, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 393 +2 391

async chunks size

id value diff baseline
infra 3.6MB +42.0B 3.6MB
monitoring 1.1MB -10.0B 1.1MB
triggers_actions_ui 725.8KB +21.0B 725.8KB
total - +53.0B -

page load bundle size

id value diff baseline
data 1.4MB -16.0B 1.4MB
lens 841.0KB +21.0B 841.0KB
ml 4.3MB +893.0B 4.3MB
total - +898.0B -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM, also did a local test. For reference: Those tooltips are used for the swim lanes and metric charts in Anomaly Explorer as well as the main chart in Single Metric Viewer.

@clintandrewhall clintandrewhall merged commit 719c292 into elastic:master Jul 29, 2020
@clintandrewhall clintandrewhall deleted the storybook-5.3 branch July 29, 2020 14:00
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jul 29, 2020
@clintandrewhall @spalger
[kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
d58f197 
Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	yarn.lock
@clintandrewhall clintandrewhall mentioned this pull request Jul 29, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
clintandrewhall added a commit that referenced this pull request Jul 30, 2020
@clintandrewhall @spalger @elasticmachine
[7.x] [kbn-storybook] Update Storybook to 5.3.19 (#73320) (#73671)
04b09ef 
Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@streamich streamich Awaiting requested review from streamich

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Storybook release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clintandrewhall @elasticmachine @kibanamachine @walterra @spalger