Fix make lint on Python 3.10#1565
Merged
pquentin merged 2 commits intoelastic:masterfrom Aug 30, 2022
Merged
Conversation
In practice this means upgrading pylint which was failing on 3.9 and 3.10.
Contributor
|
The Do you want to disable this for now? |
Member
Author
|
For now I'm more concerned by the fact that I'm not seeing those errors locally! Do you see them when running |
Contributor
I also don't see the above mentioned errors when I run this PR locally with a clean venv using Kind of unrelated, |
Member
Author
|
I ended up just disabling that check like I've done in esbench as it's of low value anyway. |
Member
Author
Thanks! I opened #1567 to address this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice this means upgrading pylint which was failing on 3.9 and 3.10.
I would like to use Python 3.10 as my daily driver to avoid discovering issues like #1484 only through our users, but I could not run
make linton Python 3.10 which made this impractical.