Skip to content

Fix make lint on Python 3.10#1565

Merged
pquentin merged 2 commits intoelastic:masterfrom
pquentin:pylint-upgrade
Aug 30, 2022
Merged

Fix make lint on Python 3.10#1565
pquentin merged 2 commits intoelastic:masterfrom
pquentin:pylint-upgrade

Conversation

@pquentin
Copy link
Copy Markdown
Member

In practice this means upgrading pylint which was failing on 3.9 and 3.10.

I would like to use Python 3.10 as my daily driver to avoid discovering issues like #1484 only through our users, but I could not run make lint on Python 3.10 which made this impractical.

In practice this means upgrading pylint which was failing on 3.9 and
3.10.
@pquentin pquentin self-assigned this Aug 24, 2022
@michaelbaamonde
Copy link
Copy Markdown
Contributor

The precommit check failed because the similarities checker found several violations of duplicate-code.

Do you want to disable this for now?

@pquentin
Copy link
Copy Markdown
Member Author

For now I'm more concerned by the fact that I'm not seeing those errors locally! Do you see them when running make lint?

@dliappis
Copy link
Copy Markdown
Contributor

For now I'm more concerned by the fact that I'm not seeing those errors locally! Do you see them when running make lint?

I also don't see the above mentioned errors when I run this PR locally with a clean venv using make lint or make precommit.
I am using Python 3.8.13.

Kind of unrelated, make install reports:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
hatchling 1.6.0 requires pluggy>=1.0.0, but you have pluggy 0.13.1 which is incompatible.

@pquentin
Copy link
Copy Markdown
Member Author

I ended up just disabling that check like I've done in esbench as it's of low value anyway.

@pquentin
Copy link
Copy Markdown
Member Author

Kind of unrelated, make install reports:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
hatchling 1.6.0 requires pluggy>=1.0.0, but you have pluggy 0.13.1 which is incompatible.

Thanks! I opened #1567 to address this.

Copy link
Copy Markdown
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit 95ae224 into elastic:master Aug 30, 2022
@pquentin pquentin added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 2, 2022
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin deleted the pylint-upgrade branch February 16, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:misc Changes that don't affect users directly: linter fixes, test improvements, etc. tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants