Merged
Conversation
This will fix the pluggy incompatibility between hatchling and pytest.
pquentin
commented
Aug 26, 2022
Member
Author
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
I've left comments about places that are not exercised by CI and explain the docs/conf.py change.
| source_suffix = ".rst" | ||
| root_doc = "index" | ||
| language = None | ||
| language = "en" |
Member
Author
There was a problem hiding this comment.
This is required by Sphinx 5
Comment on lines
-99
to
+100
| "twine==1.15.0", | ||
| "twine==4.0.1", |
Member
Author
There was a problem hiding this comment.
No breaking changes between those two versions
Comment on lines
-101
to
+102
| "github3.py==1.3.0", | ||
| "github3.py==3.2.0", |
Member
Author
There was a problem hiding this comment.
This is only used by changelog.py and it continues to work.
| "tox==3.14.0", | ||
| "sphinx==4.2.0", | ||
| "pytest==7.1.2", | ||
| "pytest-benchmark==3.4.1", |
Member
Author
There was a problem hiding this comment.
make benchmark continues to work
Member
Author
There was a problem hiding this comment.
However it notices a bug in benchmarks/driver/runner_test.py where we call bulk_index but this is an async function and it's never awaited so the benchmark is bogus. pytest-benchmark does not support asyncio though: ionelmc/pytest-benchmark#66
pquentin
force-pushed
the
bump-develop-dependencies
branch
from
1704ea9 to
bd906bf
Compare
pquentin
force-pushed
the
bump-develop-dependencies
branch
from
8a98d88 to
bd906bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the pluggy incompatibility between hatchling and pytest.
As noticed here: #1565 (comment)