Add additional filter options to rally list races#1597
Add additional filter options to rally list races#1597ebadyano merged 5 commits intoelastic:masterfrom
Conversation
ebadyano
added
enhancement
ebadyano
changed the title
ebadyano
requested review from
michaelbaamonde
and removed request for
DJRickyB
michaelbaamonde
left a comment
michaelbaamonde
left a comment
There was a problem hiding this comment.
I tested out the basic functionality with both a local and remote metrics store and it worked well! This is a very nice improvement, thanks.
In addition to my comments on adjusting the help text, I think we should add a unit test for the new filtering logic contained in metrics.py.
| help="Limit the number of search results for recent races (default: 10).", | ||
| default=10, | ||
| ) | ||
| list_parser.add_argument( |
There was a problem hiding this comment.
With the way things are structured right now, all list commands will accept these new race-specific arguments, but can't do anything useful with them. It's not a huge deal, but seeing them in the --help output for something like esrally list tracks --help could add some confusion.
That said, there's already precedent for this. --limit only really applies to races, but you can pass it to any other list subcommand.
Could you perhaps change the help text for the new arguments to indicate that they're intended to be used for races only? Something like Show only races for this track in this case, for example.
There was a problem hiding this comment.
I think the plan is to add list annotations eventually, which --track and --to-date/--from-date options should be applicable as well. I could change to records to races for now and change it back to records once list annotations is implemented.. what do you think?
There was a problem hiding this comment.
Ah, interesting. That works for me. Like I said, not a huge deal anyway.
|
@michaelbaamonde thank you for your review. I added unit tests for the new filter logic. Thank you! |
Added the following helper admin function: delete a race from Elasticsearch metric store. Use `esrally delete race --id=..` Relates to #1597
3 participants
ES Version,RevisionandRally Version).Track Parametersfrom being displayed, as for some races (e.g. logs) it's very long and makes it hard to understand the output.--track,--nameand--to-date,--from-date