Add ability to delete race from metric store#1620
Conversation
# Conflicts: # esrally/metrics.py
# Conflicts: # esrally/metrics.py
# Conflicts: # esrally/metrics.py
# Conflicts: # esrally/metrics.py
ebadyano
changed the title
ebadyano
changed the title
|
@elasticmachine run rally/rally-tracks-compat |
DJRickyB
left a comment
DJRickyB
left a comment
There was a problem hiding this comment.
This LGTM, with one thought in comments
| self.race_store.delete_race() | ||
| expected_query = {"query": {"bool": {"filter": [{"term": {"environment": "unittest-env"}}, {"term": {"race-id": "0101"}}]}}} | ||
| self.es_mock.delete_by_query.assert_called_with(index="rally-results-*", body=expected_query) | ||
|
|
There was a problem hiding this comment.
Is the print(f"Did not find [{race_id}] in environment [{environment}].") error important enough to assert happened here?
There was a problem hiding this comment.
I don't know, but can we please switch to console.println instead?
There was a problem hiding this comment.
added test, and changed to console. thank you
|
Why did we add _chart_type and _chart_name in this pull request? At a cursory glance they seem unused |
@pquentin I think that's from me not properly separating add annotations changes from this pull request. some leftovers after i split them up. |
|
@ebadyano Thanks. However today in rally master they still seem unused. |
pquentin
added
the
:internal
3 participants
Added the following helper admin function:
esrally delete race --id=..Relates to #1597