Add serverless-aware runners#1789
Merged
gbanasiak merged 3 commits intoelastic:masterfrom Oct 16, 2023
Merged
Conversation
b-deam
reviewed
Oct 9, 2023
b-deam
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes configuration context to
Query,DeleteIndexandDeleteComposableTemplaterunners to make them serverless-aware and change their behaviour if Rally targets serverless cluster.Changes:
Query,DeleteIndexandDeleteComposableTemplatestop getting and setting cluster settings throughset_destructive_requires_name()as cluster settings are not available to serverless users. In case ofDeleteIndexthis replaces the earlier crude workaround throughcontextlib.suppressintroduced in Fix serverless public use in trivial tracks #1785.DeleteComposableTemplaterunner starts to ignoredelete_matching_indicestemplate option. Wildcard deletes are not available to serverless users (!).DeleteIndexTemplaterunner is not fixed as legacy templates are not available in serverless.Queryrunner (search,paginated-search,composite-aggandscroll-searchoperations). In non-serverless use we typically rely on"index.requests.cache.enable": falseindex setting for this purpose but it is not available to serverless users. As part of this change I've removed request params in/_search/scrollwhich is present in certainQueryscenarios, as/_search/scrolldoes not acceptrequest_cacheparameter and it is the only parameter used.