Fix serverless public use in trivial tracks#1785
Merged
gbanasiak merged 1 commit intoelastic:masterfrom Sep 26, 2023
Merged
Conversation
Member
|
I'm not sure why this is a draft, this is a good step forward, as shown by the serverless IT tests that report a different error now. |
Contributor
Author
|
@pquentin Many thanks for a quick review. I've left it in draft mode while waiting for the tests to complete, but I wasn't planning to add anything. |
This was referenced Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates the following blocking points for Rally public use against serverless clusters:
driver.Driver.prepare_benchmark()method callsclient.wait_for_rest_layer()which includes_cluster/healthES API call. This is not available in serverless, but at this point we have already confirmed REST API availability inBenchmarkCoordinator.setup()throughclient.factory.cluster_distribution_version().on_benchmark_stop()intelemetryis incorrectly trying to stop all telemetry devices even if they were determined to be unsuitable for serverless, seeon_benchmark_start().DeleteIndexrunner includes a call toset_destructive_requires_name()method which relies on_cluster/settingsAPI which is not available in serverless.With the fixes in it's now possible to run trivial benchmarks with
delete-index,create-indexandbulkoperations.There are many index settings that will still prevent completion of benchmarks from https://github.com/elastic/rally-tracks but this will be addressed separately.