Skip to content

Retrieve cluster info in serverless public mode#1790

Merged
gbanasiak merged 1 commit intoelastic:masterfrom
gbanasiak:fix-retrieve-cluster-info
Oct 16, 2023
Merged

Retrieve cluster info in serverless public mode#1790
gbanasiak merged 1 commit intoelastic:masterfrom
gbanasiak:fix-retrieve-cluster-info

Conversation

@gbanasiak
Copy link
Copy Markdown
Contributor

#1785 bypassed client.wait_for_rest_layer() call in driver.Driver.prepare_benchmark() but unnecessarily also bypassed retrieve_cluster_info() method. This PR fixes this.

Before the change:

% esrally race --track=geonames --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --test-mode                                      
[..]
[INFO] Race id is [b109fef1-5f31-4e63-92c5-dc3a6a10c3a1]
[INFO] Detected Elasticsearch Serverless mode with operator=[False].
[INFO] Excluding [check-cluster-health], [force-merge], [wait-until-merges-finish], [index-stats], [node-stats] as challenge [append-no-conflicts] is run on serverless.
[INFO] Racing on track [geonames], challenge [append-no-conflicts] and car ['external'] with version [oss]. <--- HERE

After:

% esrally race --track=geonames --target-hosts=${ES_HOST}:443 --pipeline=benchmark-only --client-options="use_ssl:true,api_key:${ES_API_KEY}" --on-error=abort --test-mode
[..]
[INFO] Race id is [b7a2f8a9-8c58-4690-aaa2-0d2424ee7f37]
[INFO] Detected Elasticsearch Serverless mode with operator=[False].
[INFO] Excluding [check-cluster-health], [force-merge], [wait-until-merges-finish], [index-stats], [node-stats] as challenge [append-no-conflicts] is run on serverless.
[INFO] Racing on track [geonames], challenge [append-no-conflicts] and car ['external'] with version [8.11.0]. <--- HERE

@gbanasiak gbanasiak requested a review from a team October 9, 2023 20:05
@gbanasiak gbanasiak added this to the 2.10.0 milestone Oct 12, 2023
@gbanasiak gbanasiak added the bug Something's wrong label Oct 12, 2023
Copy link
Copy Markdown
Member

@b-deam b-deam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@gbanasiak gbanasiak merged commit bdd4640 into elastic:master Oct 16, 2023
@gbanasiak gbanasiak deleted the fix-retrieve-cluster-info branch October 16, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something's wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants