Skip to content

ci: Fix lint errors due to mypy with python 3.12 #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
favilo merged 6 commits into from
Nov 18, 2024
Merged

ci: Fix lint errors due to mypy with python 3.12 #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a325ab7
ci: Fix lint errors.
Nov 13, 2024
737a7ff
fix: Pin `aiohttp` to fix lint error
Nov 13, 2024
9d404b5
fix: downgrade aiohttp because of python 3.8 support
Nov 14, 2024
20595d4
fix: Add `type: ignore` back, until we drop support for python 3.8
Nov 14, 2024
eddc70c
Pin at 3.10.11 instead of 3.10.8
gbanasiak Nov 18, 2024
9ed4294
Remove ignore again
gbanasiak Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion esrally/client/asynchronous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ async def send(self, conn: "Connection") -> "ClientResponse":
self.response = self.response_class(
self.method,
self.original_url,
writer=self._writer, # type: ignore[arg-type] # TODO remove this ignore when introducing type hints
writer=self._writer,
continue100=self._continue,
timer=self._timer,
request_info=self.request_info,
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ classifiers = [
################################################################################################
dependencies = [
# License: Apache 2.0
# transitive dependencies:
# urllib3: MIT
# aiohttp: Apache 2.0

"elasticsearch[async]==8.6.1",
"elastic-transport==8.4.1",
# License: MIT
Copy link
Copy Markdown
Contributor Author

@favilo favilo Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also moved the license comment to here.

"urllib3==1.26.19",
# License: Apache 2.0
"aiohttp==3.10.11",
"docker==6.0.0",
# avoid specific requests version to fix bug in docker-py
"requests<2.32.0",
Expand Down