ci: Fix lint errors due to mypy with python 3.12#1890
Conversation
Now that we're using python 3.12 for the `lint` github action, we need to fix the errors that it is reporting.
|
This is caused by After local venv recreation: It's either/or it seems. Either we pin |
|
How about we pin to the current version. Then we can remove the ignore and have an updated dependency, without being forced to upgrade from an unpinned one. |
Also reorganize the transitive dependencies in pyproject.toml
|
|
||
| "elasticsearch[async]==8.6.1", | ||
| "elastic-transport==8.4.1", | ||
| # License: MIT |
There was a problem hiding this comment.
I've also moved the license comment to here.
|
Ah, so currently Python 3.8 isn't supported. So I'll pin it to 3.10.8. But I'm going to take this opportunity to just remove python 3.8 support in the near future. I've already got it working with 3.12 just fine. That will allow us to do a lot more of the improvements we were interested in doing, too. |
pyproject.toml
Outdated
| # License: MIT | ||
| "urllib3==1.26.19", | ||
| # License: Apache 2.0 | ||
| "aiohttp==3.10.8", |
There was a problem hiding this comment.
Nit: The latest 3.10.x is 3.10.11, actually.
There was a problem hiding this comment.
I think we were inspired by the state of my local env too much, so eddc70c.
Now that we're using python 3.12 for the
lintgithub action, we need to fix the errors that it is reporting.Lint errors in question
make check-allsuccessfully?