fix: Use named parameter for _to_datetime to pass default_tz#1891
Merged
favilo merged 1 commit intoelastic:masterfrom Nov 18, 2024
Merged
fix: Use named parameter for _to_datetime to pass default_tz#1891favilo merged 1 commit intoelastic:masterfrom
_to_datetime to pass default_tz#1891favilo merged 1 commit intoelastic:masterfrom
Conversation
favilo
changed the title
_to_datetime to pass default_tz
Contributor
Author
|
Sigh, can't merge until #1890 can fix the lints |
I noticed in the PST timezone, tests/track/loader_test.py::TestTemplateRender::test_render_simple_template was failing because the default timezone wasn't getting set correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in the PST timezone,
tests/track/loader_test.py::TestTemplateRender::test_render_simple_templatewas failing because the default timezone wasn't getting set correctly.