Hide the names of banned users behind a spoiler tag by andybalaam · Pull Request #32424 · element-hq/element-web

andybalaam · 2026-02-09T16:47:06Z

Make banned users' names (which may be offensive) hidden by default.

Demo

rec-2026-02-09_16.43.32.mp4

t3chguy · 2026-02-09T17:20:13Z

Tweaked title, originally thought "banned names" was like profanity detection or something

jimmackenzie · 2026-02-13T14:39:07Z

T&S team feedback: this is a welcome change - it materially improves the status quo.

Longer term, we'd be interested in exploring whether those events should be displayed in the timeline, or be viewable elsewhere. This is a welcome incremental change while we debate that question!

src/TextForEvent.tsx

t3chguy · 2026-02-13T16:49:27Z

src/TextForEvent.tsx

+                    ? _t("timeline|m.room.member|ban_reason", { senderName, targetName: "<<TARGET>>", reason })
+                    : _t("timeline|m.room.member|ban", { senderName, targetName: "<<TARGET>>" });
+                const targetI = text.indexOf("<<TARGET>>");


This is all sorts of wild, we should not be doing things like this, the 3rd param to _t can apply React element replacers, it may need updates to the i18n strings but that is worth everyone's collective sanity. Again see textForJoinRulesEvent for an example.

Yeah, didn't think this was the right way! Hopefully better attempt in 42986fc

t3chguy · 2026-02-20T09:10:11Z

Going to request design review as spoilers are something which is seldom seen by users and not sure if design ever signed them off, this will be putting them a lot more front and centre

src/i18n/strings/en_EN.json

src/components/views/elements/EventListSummary.tsx

src/TextForEvent.tsx

amshakal · 2026-02-20T09:54:46Z

I think this is a wonderful idea. Is it using the same spolier UI we already have on element web?

t3chguy · 2026-02-20T09:56:45Z

@amshakal yes it is, with the known issue that spoilers do not work for users relying on accessible technologies such as screen readers

t3chguy · 2026-02-20T12:37:25Z

src/TextForEvent.tsx

+            return allowJSX
+                ? reason
+                    ? () =>
+                          _t(
+                              "timeline|m.room.member|ban_reason_spoiler",
+                              {
+                                  senderName,
+                                  reason,
+                              },
+                              {
+                                  user: () => <Spoiler>{targetName}</Spoiler>,
+                              },
+                          )
+                    : () =>
+                          _t(
+                              "timeline|m.room.member|ban_spoiler",
+                              {
+                                  senderName,
+                                  reason,
+                              },
+                              {
+                                  user: () => <Spoiler>{targetName}</Spoiler>,
+                              },
+                          )
+                : reason
+                  ? () => _t("timeline|m.room.member|ban_reason", { senderName, targetName, reason })
+                  : () => _t("timeline|m.room.member|ban", { senderName, targetName });


please no, nested ternary is hellish. I suggest looking at the previous example I pointed you to for something to copy

Fixed in latest.

t3chguy

LGTM otherwise

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.11` → `v1.12.12` | --- ### Release Notes <details> <summary>element-hq/element-web (vectorim/element-web)</summary> ### [`v1.12.12`](https://github.com/element-hq/element-web/releases/tag/v1.12.12) [Compare Source](element-hq/element-web@v1.12.11...v1.12.12) #### ✨ Features - Add stable support for MSC4380 invite blocking ([#31966](element-hq/element-web#31966)). Contributed by [@richvdh](https://github.com/richvdh). - Hide the names of banned users behind a spoiler tag ([#32424](element-hq/element-web#32424)). Contributed by [@andybalaam](https://github.com/andybalaam). - Room list: remove bold effect on selected room ([#32593](element-hq/element-web#32593)). Contributed by [@florianduros](https://github.com/florianduros). - Use Compound buttons in auth screens ([#32562](element-hq/element-web#32562)). Contributed by [@t3chguy](https://github.com/t3chguy). - Track room list sorting algorithm changes ([#32556](element-hq/element-web#32556)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Update `sso_redirect_options` to work for Native OIDC ([#32537](element-hq/element-web#32537)). Contributed by [@t3chguy](https://github.com/t3chguy). #### 🐛 Bug Fixes - Room list: avoid excessive re-renders on room list store update or filter change ([#32663](element-hq/element-web#32663)). Contributed by [@florianduros](https://github.com/florianduros). - Room list: listen to call event to check number of participants ([#32677](element-hq/element-web#32677)). Contributed by [@florianduros](https://github.com/florianduros). - Fix invite-specific join errors not being shown ([#32621](element-hq/element-web#32621)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Prevent logging lots of "Browser unsupported" lines ([#32647](element-hq/element-web#32647)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Update critical gradient for room status bar ([#32575](element-hq/element-web#32575)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Room list: avoid header overflowing when too long ([#32645](element-hq/element-web#32645)). Contributed by [@florianduros](https://github.com/florianduros). - Room list: center focus outline of room list item ([#32637](element-hq/element-web#32637)). Contributed by [@florianduros](https://github.com/florianduros). - Fix misaligned cross in complete security dialog ([#32614](element-hq/element-web#32614)). Contributed by [@dbkr](https://github.com/dbkr). - Room list: fix keyboard navigation ([#32585](element-hq/element-web#32585)). Contributed by [@florianduros](https://github.com/florianduros). - Don't show empty privacy section ([#32582](element-hq/element-web#32582)). Contributed by [@dbkr](https://github.com/dbkr). - Disable room list image dragging ([#32590](element-hq/element-web#32590)). Contributed by [@florianduros](https://github.com/florianduros). - Update UserMenu theme toggle to use IconButton ([#32591](element-hq/element-web#32591)). Contributed by [@t3chguy](https://github.com/t3chguy). - Room list: make room list item scales with large font size ([#32523](element-hq/element-web#32523)). Contributed by [@florianduros](https://github.com/florianduros). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4596 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

github-actions bot requested a deployment to Netlify February 9, 2026 16:53 In progress

t3chguy changed the title ~~WIP: spoilers on banned names~~ WIP: spoilers on banned users' names Feb 9, 2026

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from b3ceecc to 3127eac Compare February 10, 2026 11:05

andybalaam added the T-Enhancement label Feb 10, 2026

github-actions bot deployed to Netlify February 10, 2026 11:09 View deployment

github-actions bot deployed to EndToEndTests February 10, 2026 11:21 View deployment

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from 3127eac to 314b1c7 Compare February 10, 2026 13:28

github-actions bot deployed to Netlify February 10, 2026 13:31 View deployment

github-actions bot deployed to EndToEndTests February 10, 2026 13:45 View deployment

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from 314b1c7 to d6941d0 Compare February 13, 2026 13:56

github-actions bot deployed to Netlify February 13, 2026 13:58 View deployment

andybalaam changed the title ~~WIP: spoilers on banned users' names~~ Hide the names of banned users behind a spoiler tag Feb 13, 2026

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from d6941d0 to 7e3fc72 Compare February 13, 2026 14:00

github-actions bot deployed to Netlify February 13, 2026 14:02 View deployment

github-actions bot deployed to EndToEndTests February 13, 2026 14:13 View deployment

andybalaam marked this pull request as ready for review February 13, 2026 14:14

andybalaam requested a review from a team as a code owner February 13, 2026 14:14

andybalaam requested review from MidhunSureshR and t3chguy February 13, 2026 14:14

t3chguy requested changes Feb 13, 2026

View reviewed changes

andybalaam requested a review from t3chguy February 19, 2026 17:23

github-actions bot deployed to Netlify February 19, 2026 17:24 View deployment

github-actions bot deployed to EndToEndTests February 19, 2026 17:36 View deployment

t3chguy requested a review from a team February 20, 2026 09:10

t3chguy reviewed Feb 20, 2026

View reviewed changes

src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved

src/components/views/elements/EventListSummary.tsx Outdated Show resolved Hide resolved

src/TextForEvent.tsx Outdated Show resolved Hide resolved

src/TextForEvent.tsx Outdated Show resolved Hide resolved

github-actions bot deployed to Netlify February 20, 2026 11:27 View deployment

github-actions bot deployed to Netlify February 20, 2026 11:30 View deployment

andybalaam requested a review from t3chguy February 20, 2026 11:40

github-actions bot deployed to Netlify February 20, 2026 11:42 View deployment

andybalaam requested a review from a team as a code owner February 20, 2026 11:47

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from 0f03422 to 948a1dd Compare February 20, 2026 12:03

github-actions bot deployed to Netlify February 20, 2026 12:05 View deployment

github-actions bot deployed to EndToEndTests February 20, 2026 12:17 View deployment

t3chguy reviewed Feb 20, 2026

View reviewed changes

t3chguy approved these changes Feb 20, 2026

View reviewed changes

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from 948a1dd to 8244607 Compare February 20, 2026 13:12

Hide the names of banned users behind a spoiler tag

3ca5726

andybalaam force-pushed the andybalaam/spoiler-banned-names branch from 8244607 to 3ca5726 Compare February 20, 2026 13:12

github-actions bot deployed to Netlify February 20, 2026 13:15 View deployment

github-actions bot deployed to EndToEndTests February 20, 2026 13:26 View deployment

andybalaam added this pull request to the merge queue Feb 23, 2026

Merged via the queue into develop with commit 41f8fff Feb 23, 2026
39 checks passed

andybalaam deleted the andybalaam/spoiler-banned-names branch February 23, 2026 13:49

This was referenced Feb 25, 2026

Event list summaries are arranged in an unusual layout #32631

Closed

Revert 'Hide the names of banned users behind a spoiler tag#32424' #32635

Merged

Uh oh!

Conversation

andybalaam commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

Uh oh!

t3chguy commented Feb 9, 2026

Uh oh!

jimmackenzie commented Feb 13, 2026

Uh oh!

Uh oh!

t3chguy Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andybalaam Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

t3chguy commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amshakal commented Feb 20, 2026

Uh oh!

t3chguy commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t3chguy Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

andybalaam Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

t3chguy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andybalaam commented Feb 9, 2026 •

edited

Loading

t3chguy Feb 13, 2026 •

edited

Loading

t3chguy commented Feb 20, 2026 •

edited

Loading