Skip to content

Fix invite-specific join errors not being shown#32621

Merged
Half-Shot merged 7 commits intodevelopfrom
hs/fix-failed-to-join-message
Feb 27, 2026
Merged

Fix invite-specific join errors not being shown#32621
Half-Shot merged 7 commits intodevelopfrom
hs/fix-failed-to-join-message

Conversation

@Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Feb 24, 2026

Unsure whether to say this "fixes" #32620 , it simply makes the error less crap.

This fixes:

  • A bug where we would overwrite invite specific errors
  • The lack of tests around that area
  • A lack of type-checking on JoinRoomErrorPayload.

Checklist

@Half-Shot Half-Shot requested a review from a team as a code owner February 24, 2026 15:16
Half-Shot
Half-Shot commented Feb 24, 2026
View reviewed changes
apps/web/src/stores/RoomViewStore.tsx
public showJoinRoomError(err: unknown, roomId: string | null): void {
let description: ReactNode = err instanceof Error && err.message ? err.message : JSON.stringify(err);
if (err instanceof MatrixError === false) {
// This isn't a MatrixError so just show the error verbatim.
Copy link
Member Author

@Half-Shot Half-Shot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is horrible i18n-wise, but it matches present behaviour 🤷

Half-Shot
Half-Shot commented Feb 24, 2026
View reviewed changes
apps/web/src/stores/RoomViewStore.tsx
@@ -631,6 +630,7 @@ export class RoomViewStore extends EventEmitter {
);
}
}
logger.log("Failed to join room:", description);
Copy link
Member Author

@Half-Shot Half-Shot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the error to log description, which might not actually be what we want to do. Should we be logging the err?

@Half-Shot Half-Shot mentioned this pull request Feb 24, 2026
Open
t3chguy
t3chguy reviewed Feb 26, 2026
View reviewed changes
t3chguy
t3chguy reviewed Feb 27, 2026
View reviewed changes
@Half-Shot Half-Shot enabled auto-merge February 27, 2026 10:48
@Half-Shot Half-Shot added this pull request to the merge queue Feb 27, 2026
Merged via the queue into develop with commit 89fb388 Feb 27, 2026
42 checks passed
@Half-Shot Half-Shot deleted the hs/fix-failed-to-join-message branch February 27, 2026 11:17
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Mar 10, 2026
@alexlebens
chore(deps): update vectorim/element-web docker tag to v1.12.12 (#4596)
def594a 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.11` → `v1.12.12` |

---

### Release Notes

<details>
<summary>element-hq/element-web (vectorim/element-web)</summary>

### [`v1.12.12`](https://github.com/element-hq/element-web/releases/tag/v1.12.12)

[Compare Source](element-hq/element-web@v1.12.11...v1.12.12)

#### ✨ Features

- Add stable support for MSC4380 invite blocking ([#&#8203;31966](element-hq/element-web#31966)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).
- Hide the names of banned users behind a spoiler tag ([#&#8203;32424](element-hq/element-web#32424)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).
- Room list: remove bold effect on selected room ([#&#8203;32593](element-hq/element-web#32593)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Use Compound buttons in auth screens ([#&#8203;32562](element-hq/element-web#32562)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Track room list sorting algorithm changes ([#&#8203;32556](element-hq/element-web#32556)). Contributed by [@&#8203;MidhunSureshR](https://github.com/MidhunSureshR).
- Update `sso_redirect_options` to work for Native OIDC ([#&#8203;32537](element-hq/element-web#32537)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).

#### 🐛 Bug Fixes

- Room list: avoid excessive re-renders on room list store update or filter change ([#&#8203;32663](element-hq/element-web#32663)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Room list: listen to call event to check number of participants ([#&#8203;32677](element-hq/element-web#32677)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Fix invite-specific join errors not being shown ([#&#8203;32621](element-hq/element-web#32621)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- Prevent logging lots of "Browser unsupported" lines ([#&#8203;32647](element-hq/element-web#32647)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- Update critical gradient for room status bar ([#&#8203;32575](element-hq/element-web#32575)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- Room list: avoid header overflowing when too long ([#&#8203;32645](element-hq/element-web#32645)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Room list: center focus outline of room list item ([#&#8203;32637](element-hq/element-web#32637)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Fix misaligned cross in complete security dialog ([#&#8203;32614](element-hq/element-web#32614)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Room list: fix keyboard navigation ([#&#8203;32585](element-hq/element-web#32585)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Don't show empty privacy section ([#&#8203;32582](element-hq/element-web#32582)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Disable room list image dragging ([#&#8203;32590](element-hq/element-web#32590)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Update UserMenu theme toggle to use IconButton ([#&#8203;32591](element-hq/element-web#32591)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Room list: make room list item scales with large font size ([#&#8203;32523](element-hq/element-web#32523)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41OS4yIiwidXBkYXRlZEluVmVyIjoiNDMuNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4596
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

No one assigned

Labels

T-Defect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Half-Shot @t3chguy