Fix: use correct parameter when calling get_local_current_membership_for_user_in_room

[lukastautz]

I noticed that I incorrectly got permission errors, and discovered that _user_can_see_state_at_event uses event_id instead of room_id when calling get_local_current_membership_for_user_in_room, which obviously can't work.

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Code style is correct (run the linters)

[anoadragon453]

Thanks, good catch!

Ideally we'd have a regression test for this change so we automatically catch it in the future. Would you separately be willing to write one in our integration test suite, somewhere around here?

[MadLittleMods]

We could probably catch this better if we enforced keyword args on get_local_current_membership_for_user_in_room(...):

    async def get_local_current_membership_for_user_in_room(
        self, *, user_id: str, room_id: str
    ) -> tuple[str | None, str | None]:

In this usage, we would see room_id=event_id which won't be picked up by the linter but is more obvious to the eyes as a mistake.

Additionally, these are both str args which could be confused on order.

[anoadragon453]

Good point for making wider use of kwargs!