Closed
Conversation
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
So I love the other 2 sticky PRs but I actually don't think we want this 🤔 we can discuss it at one of our meetings if you like? |
Member
Author
|
Mostly based this on other docs websites which mostly all have a sticky header. I do see the benefit of always having the search field available without having to scroll to the top. I think the other stickyness updates work fine without this. I agree it is odd that we would make the header sticky here while it isn't on other pages using the same component. Let's pick it up in a sync, or just leave it out for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #185
Makes the header sticky, so all navigation is accessible when scrolling.